Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a few prerelease improvements #405

Merged
merged 5 commits into from
Mar 16, 2017
Merged

a few prerelease improvements #405

merged 5 commits into from
Mar 16, 2017

Conversation

dirk-thomas
Copy link
Member

  • Change the default of the --level argument to 0 since it is the most common value (2 doesn't make much sense in many cases).
  • Skip processing the overlay workspace if it is empty anyway (saving quite some time).
  • Fix the prerelease script when using only external repos which don't have any source entries in the distro.

@dirk-thomas dirk-thomas self-assigned this Mar 16, 2017
@dirk-thomas dirk-thomas mentioned this pull request Mar 16, 2017
Closed
@dirk-thomas dirk-thomas mentioned this pull request Mar 16, 2017
Closed
@mathias-luedtke
Copy link
Contributor

works like a charm (ros-industrial/industrial_ci#145)

@dirk-thomas
Copy link
Member Author

@ipa-mdl Thank you for the feedback.

@mathias-luedtke mathias-luedtke mentioned this pull request Mar 16, 2017
Merged
@dirk-thomas dirk-thomas merged commit 02ebc66 into master Mar 16, 2017
@dirk-thomas dirk-thomas deleted the prerelease_improvements branch March 16, 2017 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dirk-thomas dirk-thomas

Labels
in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirk-thomas @mathias-luedtke