Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handle installed virtual packages #468

Merged

Conversation

kopp
Copy link
Contributor

@kopp kopp commented Jul 19, 2016

When a virtual package is requested by a rosdep.yaml file, that was not recognized as being installed because it is not found by dpkg-query. This patch searches for virtual packages using apt show and if it's a virtual package searches for the providing actual packages using apt-cache.

If python-apt (python api package for apt) is allowed as new dependency, this could be handled more easily -- see the comment in _is_installed_as_virtual_package.

@kopp
Copy link
Contributor Author

kopp commented Jul 20, 2016

This is a first step for #274: When a package providing a virtual package is present, the virtual package is considered installed. If you try to install a virtual package, apt should make sure that you get some package installed, that provides this virtual package.

@tfoote
Copy link
Member

tfoote commented Jul 26, 2016

This looks valuable. Thanks for the contribution.

The additional dependency on python-apt might be reasonable. As long as it's available very generally on all platforms in a new enough version.

@wjwwood
Copy link
Contributor

wjwwood commented Aug 24, 2016

Thanks for the contribution @kopp. This looks good as is. My instinct is to merge it as is and track the option to use python-apt as an enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants