normalize list of uninstalled to single list of str #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #524
For the original issue. This just works around the fact that the "uninstalled" is returned in a different data layout in some cases with Homebrew by normalizing it into a list of str's before trying to join it.
I looked at why the data layout is different, but the function declares that the layout is "opaque" as it is passed up from the installer and then back into it again without being used (except to print in verbose mode, which is why this came up). I think the difference is important to the function of the Homebrew implementation. I didn't want to refactor it completely, so I just made the printing functions more flexible.