Clean up shebang warnings #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two classes of changes here: 1. `catkin_support.py` is executable, but has no shebang, so I removed the executable bit. 2. `main.py` has a shebang and `__main__` handler, and I removed it. It can still be executed directly using the python executable, but like with ros-infrastructure/rospkg#159, it doesn't make sense to have executable scripts in the module.
wjwwood
approved these changes
Sep 17, 2018
tfoote
approved these changes
Sep 17, 2018
Merged
at-wat
pushed a commit
to at-wat/rosdep
that referenced
this pull request
Nov 15, 2018
Two classes of changes here: 1. `catkin_support.py` is executable, but has no shebang, so I removed the executable bit. 2. `main.py` has a shebang and `__main__` handler, and I removed it. It can still be executed directly using the python executable, but like with ros-infrastructure/rospkg#159, it doesn't make sense to have executable scripts in the module.
at-wat
added a commit
to at-wat/rosdep
that referenced
this pull request
Nov 15, 2018
same fix as ros-infrastructure#630
This was referenced Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two classes of changes here:
catkin_support.pyis executable, but has no shebang, so I removed the executable bit.main.pyand many platforms have a shebang, and I removed them. Some can still be executed directly using the python executable, but like with Clean up shebang warnings rospkg#159, it doesn't make sense to have executable scripts in the module.