Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use yaml.safe_load for untrusted yaml input #651

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

dirk-thomas
Copy link
Member

The patch only updates the invocation where untrusted sources are being processed.

@dirk-thomas dirk-thomas self-assigned this Jan 23, 2019
@dirk-thomas
Copy link
Member Author

I will leave it up to the maintainer(s) to merge and release with the CI failing.

@codecov-io
Copy link

codecov-io commented Jan 24, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@86196d6). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #651   +/-   ##
=========================================
  Coverage          ?   75.17%           
=========================================
  Files             ?       30           
  Lines             ?     2888           
  Branches          ?        0           
=========================================
  Hits              ?     2171           
  Misses            ?      717           
  Partials          ?        0
Impacted Files Coverage Δ
src/rosdep2/loader.py 80% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86196d6...e526072. Read the comment docs.

@nuclearsandwich nuclearsandwich merged commit 38a839f into master Jan 24, 2019
@nuclearsandwich nuclearsandwich deleted the use_yaml_safe_load branch January 24, 2019 16:20
@tfoote tfoote mentioned this pull request May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants