Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evaluate conditions before collecting dependencies #654

Merged
merged 1 commit into from
Jan 24, 2019
Merged

evaluate conditions before collecting dependencies #654

merged 1 commit into from
Jan 24, 2019

Conversation

dirk-thomas
Copy link
Member

Fixes #653.

@dirk-thomas dirk-thomas self-assigned this Jan 23, 2019
@dirk-thomas dirk-thomas mentioned this pull request Jan 23, 2019
Closed
@codecov-io
Copy link

codecov-io commented Jan 24, 2019 •
edited
Loading

Codecov Report

Merging #654 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
+ Coverage   75.17%   75.19%   +0.01%     
==========================================
  Files          30       30              
  Lines        2888     2890       +2     
==========================================
+ Hits         2171     2173       +2     
  Misses        717      717
Impacted Files Coverage Δ
src/rosdep2/rospkg_loader.py 93.84% <100%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3dadd...14e4a60. Read the comment docs.

wjwwood
wjwwood approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nuclearsandwich for fixing CI!

AAlon
AAlon approved these changes Jan 24, 2019
View reviewed changes
Copy link

@AAlon AAlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it fixes #653. Thanks!

@nuclearsandwich nuclearsandwich merged commit 30a631f into master Jan 24, 2019
@nuclearsandwich nuclearsandwich deleted the evaluate_conditions branch January 24, 2019 16:03
@nuclearsandwich nuclearsandwich mentioned this pull request Jan 26, 2019
Merged
@JWhitleyWork JWhitleyWork mentioned this pull request Apr 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AAlon AAlon AAlon approved these changes

@wjwwood wjwwood wjwwood approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dirk-thomas @codecov-io @wjwwood @AAlon @nuclearsandwich