Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print exception if it's of type URLError #946

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Feb 19, 2024

This prints the exception out if it's of type URLError when trying to retrieve the default rosdep source list. This is intended to help others debug #934 should they run into it.

This prints the exception out if it's of type URLError when trying to
retrieve the default rosdep source list. This is intended to help others
debug #934 should they run into it.

Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
@sloretz sloretz self-assigned this Feb 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5ca91b8) 74.22% compared to head (6a824e7) 74.20%.

Files Patch % Lines
src/rosdep2/main.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #946      +/-   ##
==========================================
- Coverage   74.22%   74.20%   -0.03%     
==========================================
  Files          44       44              
  Lines        3376     3377       +1     
==========================================
  Hits         2506     2506              
- Misses        870      871       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sloretz sloretz merged commit e48589c into master Apr 9, 2024
9 checks passed
@cottsay cottsay deleted the sloretz__print_exc_if_URLError branch April 9, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants