Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add macOS Sonoma to _osx_codename_map #262

Merged
merged 3 commits into from
Feb 17, 2024
Merged

add macOS Sonoma to _osx_codename_map #262

merged 3 commits into from
Feb 17, 2024

Conversation

kylegibson15
Copy link
Contributor

No description provided.

@kylegibson15 kylegibson15 mentioned this pull request Dec 30, 2023
Open
@christophebedard
Copy link
Member

christophebedard commented Jan 10, 2024 •
edited
Loading

Thanks for the PR! Could you run python3 -m rospkg.os_detect and provide the output just to confirm that it does indeed work? I personally do not have a Mac that I can test it on.

@kylegibson15
Copy link
Contributor Author

kylegibson15 commented Feb 9, 2024 •
edited
Loading 

OS Name:       osx
OS Version:    14.2.1
OS Codename: sonoma

cottsay
cottsay reviewed Feb 12, 2024
View reviewed changes
src/rospkg/os_detect.py Outdated Show resolved Hide resolved
@cottsay cottsay merged commit c715739 into ros-infrastructure:master Feb 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cottsay cottsay cottsay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylegibson15 @christophebedard @cottsay