More utils tests #113

allenh1 · 2018-01-04T23:07:27Z

Mark certain functions with # pragma: no cover so that they don't get counted in the coverage results, as well as add a bit more to the license tests.

allenh1@hunter-laptop ~/work/superflore $ coverage run --source=superflore -m "nose" && coverage report -m
..............................
----------------------------------------------------------------------
Ran 30 tests in 1.879s

OK
Name                                               Stmts   Miss  Cover   Missing
--------------------------------------------------------------------------------
superflore/CacheManager.py                            20     13    35%   23-24, 28-33, 37-41
superflore/TempfileManager.py                         34     23    32%   27-28, 31-41, 44-57
superflore/__init__.py                                10      4    60%   5-8
superflore/docker.py                                  32     12    62%   40, 43-59
superflore/exceptions.py                              12      3    75%   18, 28, 33
superflore/generate_installers.py                     57     48    16%   32-86
superflore/generators/__init__.py                      0      0   100%
superflore/generators/bitbake/__init__.py              3      1    67%   3
superflore/generators/bitbake/gen_packages.py        115     92    20%   40-103, 110-166, 174-182, 188
superflore/generators/bitbake/ros_meta.py             27     18    33%   24-27, 30-35, 38-51, 54-55
superflore/generators/bitbake/run.py                 113     94    17%   39-44, 51-199
superflore/generators/bitbake/yocto_recipe.py        112     92    18%   43-64, 67, 70-74, 77-89, 92-96, 99-101, 104-105, 113-116, 125-177
superflore/generators/ebuild/__init__.py               3      1    67%   3
superflore/generators/ebuild/ebuild.py               135      7    95%   125-127, 131-136
superflore/generators/ebuild/gen_packages.py         151    125    17%   45-113, 118-150, 155-211, 216-233, 236, 239
superflore/generators/ebuild/metadata_xml.py          33      0   100%
superflore/generators/ebuild/overlay_instance.py      37     25    32%   27-32, 35-45, 48-64, 67-68
superflore/generators/ebuild/run.py                  157    137    13%   40-43, 47-52, 59-250
superflore/repo_instance.py                           49     34    31%   26-35, 38-46, 49-57, 63, 69, 75, 81, 84-91
superflore/rosdep_support.py                          34      2    94%   83-84
superflore/utils.py                                  109     40    63%   54-59, 108, 114, 121-124, 126, 132, 138-139, 144, 148-149, 156-177
--------------------------------------------------------------------------------
TOTAL                                               1243    771    38%

tfoote

No covering the IO is fine, but the others I think could easily have tests written for them.

tfoote · 2018-01-08T02:52:11Z

superflore/utils.py

@@ -59,7 +59,7 @@ def get_pkg_version(distro, pkg_name):
    return maj_min_patch


-def rand_ascii_str(length=10):
+def rand_ascii_str(length=10):  # pragma: no cover


This one you could test returns only ascii characters and that the length is as expected.

Also a good point. Thanks.

tfoote · 2018-01-08T02:53:50Z

superflore/utils.py

    print(colored('>>>> {0}'.format(string), 'cyan'))


-def make_dir(dirname):
+def make_dir(dirname):  # pragma: no cover


This could be trivially tested in a tempdir. It would be good to add tests for the different edge cases such as the directory existing, not existing, is file, and not writable.

That's a good point. Will do.

outdated

allenh1 · 2018-01-08T17:02:53Z

Latest report below. Getting better! I'd say the next priority is generate_installers.py. @tfoote what do you think?

allenh1@hunter-laptop ~/work/superflore $ coverage run --source=superflore -m "nose" && coverage report -m
................................
----------------------------------------------------------------------
Ran 32 tests in 5.886s

OK
Name                                               Stmts   Miss  Cover   Missing
--------------------------------------------------------------------------------
superflore/CacheManager.py                            20     13    35%   23-24, 28-33, 37-41
superflore/TempfileManager.py                         34     12    65%   32-37, 48-56
superflore/__init__.py                                10      4    60%   5-8
superflore/docker.py                                  32     12    62%   40, 43-59
superflore/exceptions.py                              12      3    75%   18, 28, 33
superflore/generate_installers.py                     57     48    16%   32-86
superflore/generators/__init__.py                      0      0   100%
superflore/generators/bitbake/__init__.py              3      1    67%   3
superflore/generators/bitbake/gen_packages.py        115     92    20%   40-103, 110-166, 174-182, 188
superflore/generators/bitbake/ros_meta.py             27     18    33%   24-27, 30-35, 38-51, 54-55
superflore/generators/bitbake/run.py                 113     94    17%   39-44, 51-199
superflore/generators/bitbake/yocto_recipe.py        112     92    18%   43-64, 67, 70-74, 77-89, 92-96, 99-101, 104-105, 113-116, 125-177
superflore/generators/ebuild/__init__.py               3      1    67%   3
superflore/generators/ebuild/ebuild.py               143      7    95%   125-127, 131-136
superflore/generators/ebuild/gen_packages.py         151    125    17%   45-113, 118-150, 155-211, 216-233, 236, 239
superflore/generators/ebuild/metadata_xml.py          33      0   100%
superflore/generators/ebuild/overlay_instance.py      37     25    32%   27-32, 35-45, 48-64, 67-68
superflore/generators/ebuild/run.py                  157    137    13%   40-43, 47-52, 59-250
superflore/repo_instance.py                           49     34    31%   26-35, 38-46, 49-57, 63, 69, 75, 81, 84-91
superflore/rosdep_support.py                          34      2    94%   83-84
superflore/utils.py                                  118     41    65%   50, 54-59, 108, 114, 121-124, 126, 132, 138-139, 144, 148-149, 156-177
--------------------------------------------------------------------------------
TOTAL                                               1260    761    40%

tfoote

thanks for the extra tests.

* Skip print functions during coverage check. * Add more license tests. * Add test for make_dir. * Add test for random ascii strings.

allenh1 added enhancement in progress labels Jan 4, 2018

allenh1 self-assigned this Jan 4, 2018

allenh1 added in review and removed in progress labels Jan 7, 2018

allenh1 requested a review from tfoote January 7, 2018 17:52

tfoote previously requested changes Jan 8, 2018

View reviewed changes

allenh1 added 3 commits January 8, 2018 10:19

Skip print functions during coverage check.

79b980d

Don't test make directory or random strings.

93c4a65

Add more license tests.

7e2f60c

allenh1 force-pushed the more-utils-tests branch from 21ed383 to 7e2f60c Compare January 8, 2018 16:19

Add test for make_dir.

5efbaf2

allenh1 added in progress and removed in review labels Jan 8, 2018

Add test for random ascii strings.

53e83d2

allenh1 added in review and removed in progress labels Jan 8, 2018

allenh1 requested a review from tfoote January 8, 2018 16:51

tfoote approved these changes Jan 8, 2018

View reviewed changes

allenh1 merged commit f836f17 into master Jan 8, 2018

allenh1 deleted the more-utils-tests branch January 8, 2018 19:23

herb-kuta-lge removed the in review label Apr 22, 2020

zffgithub pushed a commit to zffgithub/superflore that referenced this pull request Apr 11, 2023

More utils tests (ros-infrastructure#113)

10e6ae3

* Skip print functions during coverage check. * Add more license tests. * Add test for make_dir. * Add test for random ascii strings.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More utils tests #113

More utils tests #113

allenh1 commented Jan 4, 2018

tfoote left a comment

tfoote Jan 8, 2018

allenh1 Jan 8, 2018

tfoote Jan 8, 2018

allenh1 Jan 8, 2018

allenh1 commented Jan 8, 2018

tfoote left a comment

More utils tests #113

More utils tests #113

Conversation

allenh1 commented Jan 4, 2018

tfoote left a comment

Choose a reason for hiding this comment

tfoote Jan 8, 2018

Choose a reason for hiding this comment

allenh1 Jan 8, 2018

Choose a reason for hiding this comment

tfoote Jan 8, 2018

Choose a reason for hiding this comment

allenh1 Jan 8, 2018

Choose a reason for hiding this comment

allenh1 commented Jan 8, 2018

tfoote left a comment

Choose a reason for hiding this comment