Adding coverage for exceptions.py #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenh1
reviewed
Mar 2, 2018
|
|
||
| def test_unknown_platform(self): | ||
| """Test resolve_dep with bad OS""" | ||
| with self.assertRaises(UnknownPlatform): |
There was a problem hiding this comment.
I think you need to add an import for superflore.exceptions.UnknownPlatform
allenh1
reviewed
Mar 2, 2018
tests/test_utils.py
Outdated
| def test_unknown_platform(self): | ||
| """Test resolve_dep with bad OS""" | ||
| with self.assertRaises(UnknownPlatform): | ||
| ret = rsolve_dep('cmake', 'Windoughs8') |
|
@shaneallcroft You might find it helpful to run the unit tests yourself locally before opening a pull request. You can see how the CI is running them by looking at the |
|
@tfoote Will do! Sorry for the noise. |
|
@shaneallcroft Thanks for adding that missing test! Unfortunately, the others in So, pending @tfoote's opinion, I think this can be merged. |
tfoote
approved these changes
Mar 3, 2018
zffgithub
pushed a commit
to zffgithub/superflore
that referenced
this pull request
Apr 11, 2023
* Added test for unknown platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on unchecked exceptions.