Small cleanups #169
Merged
Small cleanups #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andre-rosa
force-pushed
the
small_cleanups
branch
from
a595ea0 to
065bda0
Compare
andre-rosa
force-pushed
the
small_cleanups
branch
from
065bda0 to
0b5f647
Compare
andre-rosa
force-pushed
the
small_cleanups
branch
from
0b5f647 to
377ecc4
Compare
allenh1
suggested changes
Apr 2, 2019
There was a problem hiding this comment.
Generally looking good, but the Boost-1.0 license needs to remain (because Gentoo). I don't recall bitbake ever getting upset about this issue, so, unless this breaks things to remain (in which case we'll need to figure something else out), I need it to stay the same.
I'll make up my mind about the .vscode files in the interim.
User can stop/relaunch the superflore and then it reports error
because the superflore pushed git patch at the end of stage.
(Failed to 'git rm -f {existing}')
The error can be ignored because it will be re-generated.
andre-rosa
force-pushed
the
small_cleanups
branch
2 times, most recently
from
af191c3 to
4c58786
Compare
allenh1
approved these changes
Apr 3, 2019
|
lgtm -- waiting for @tfoote to review and we should be ready to merge this one. Thanks! |
tfoote
approved these changes
Apr 3, 2019
|
Thank you both! |
zffgithub
pushed a commit
to zffgithub/superflore
that referenced
this pull request
Apr 11, 2023
* Remove dead code and fix few typos
* Add newer ROS 2 releases
* Add missing argument to save_pr
* Simplify make_dir by removing pass
* Sync ebuild and bitbake run scripts
* Don't report error when trying to remove existing bb
User can stop/relaunch the superflore and then it reports error
because the superflore pushed git patch at the end of stage.
(Failed to 'git rm -f {existing}')
The error can be ignored because it will be re-generated.
* Fix PR title/message file names on logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separating few cleanups from #168 .