Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check missing dependencies before checking preserve_existing #194

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

andre-rosa
Copy link
Contributor

  • Gentoo expects first checking for missing dependencies before
    considering preserve_existing, so keep checks in that order.

  - Gentoo expects first checking for missing dependencies before
    considering preserve_existing, so keep checks in that order.
@andre-rosa
Copy link
Contributor Author

@allenh1 << Could you please try this and check if it fixes #193 ?

@allenh1 allenh1 self-assigned this Jun 5, 2019
@allenh1 allenh1 self-requested a review June 5, 2019 13:03
@allenh1
Copy link
Contributor

allenh1 commented Jun 5, 2019

@andre-rosa that definitely seems to have done the trick. Thanks!

@allenh1 allenh1 merged commit bdc49ff into ros-infrastructure:master Jun 5, 2019
@andre-rosa andre-rosa deleted the fix_gentoo_missing_deps branch June 5, 2019 15:42
@andre-rosa
Copy link
Contributor Author

andre-rosa commented Jun 5, 2019

Fixes #193

zffgithub pushed a commit to zffgithub/superflore that referenced this pull request Apr 11, 2023
…rastructure#194)

- Gentoo expects first checking for missing dependencies before
    considering preserve_existing, so keep checks in that order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants