Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on multirobot refactor to migration guide #609

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

luca-della-vedova
Copy link

Add migration for PR ros-navigation/navigation2#4715

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
migration/Jazzy.rst Outdated Show resolved Hide resolved
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
@@ -86,6 +86,13 @@ This costmap layer implements a plugin that uses 2D raycasting for 2D lidars, de
Description
Topic of data.

Relative topics will be relative to the node's parent namespace.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't render properly: https://output.circle-artifacts.com/output/job/190ba9cc-e4b2-4590-b0e4-838801870a4f/artifacts/0/html/configuration/packages/costmap-plugins/obstacle.html

I think that's fixed by adding an empty line before the first bullet (after the line ending with : to separate it)

@SteveMacenski
Copy link
Member

One more thing and this should be done https://docs.nav2.org/tuning/index.html --> remove the use_namespace parameter description if we're removing it

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants