Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nav2_behavior Wait is not using sim time #3780

Closed
doisyg opened this issue Aug 29, 2023 · 2 comments
Closed

nav2_behavior Wait is not using sim time #3780

doisyg opened this issue Aug 29, 2023 · 2 comments

Comments

@doisyg
Copy link
Contributor

doisyg commented Aug 29, 2023

Bug report

The Wait behavior https://github.com/ros-planning/navigation2/blob/main/nav2_behaviors/plugins/wait.cpp is not using the ROS clock and hence will not have a consistant behavior when used in sim if the real time factor is not maintained to 1

Expected behavior

Wait based on sim time when in sim

Actual behavior

Wait based on the wall clock

Additional information

Would it be okay to switch to using the ROS clock ? I can make a PR

@SteveMacenski
Copy link
Member

This is covered by #3303, but sure a PR to resolve this particular instance would be nice! We're waiting on some other things in rclcpp itself to update Rate to be able to use ROS time, but this particular instance doesn't require it

@doisyg doisyg mentioned this issue Aug 29, 2023
7 tasks
@doisyg
Copy link
Contributor Author

doisyg commented Aug 29, 2023

#3782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants