improvement and debug #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 14, 2018 23:07
…gged. New field(string str) has been added into AlvarMarker.msg (for ar_pose_marker topic). Text extraction from markers feature for individual markers has been added (into ar_pose_marker topic). Max character limit of the file name of the marker file has been increased. (+200) Filename format of the marker file has been changed. (adding resolution of the marker) Filename character checking of the marker file has been changed.
|
Thank you for the contribution (for the past few PRs too). Are you taking a look at CI failures? There's a chance that tests that are run on CI might be flaky, so if you think the root cause of CI failure isn't in your change, please just speak up so that someone (likely me...) can look into it. |
|
Thank you for your kindly comment. So, please look into it about the failures. Best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made some changes. Please review them.