Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for lazy subscribers #272

Merged
merged 1 commit into from
Jul 13, 2023
Merged

add support for lazy subscribers #272

merged 1 commit into from
Jul 13, 2023

Conversation

mikeferguson
Copy link
Member

@mikeferguson mikeferguson commented May 17, 2023 •
edited
Loading

This implements #111 for releases after Iron (where we have connect/disconnect callbacks, per ros2/rmw#330)

@mikeferguson
Copy link
Member Author

Also, not sure if rolling or ros2 is the right branch - they appear to be even with one another right now...

This was referenced May 17, 2023
Merged
Closed
@clalancette clalancette changed the base branch from ros2 to rolling May 17, 2023 12:04
@clalancette
Copy link
Contributor

Also, not sure if rolling or ros2 is the right branch - they appear to be even with one another right now...

Yeah, it is a bit messy now. rolling is the right branch, I retargeted to that.

@mikeferguson mikeferguson mentioned this pull request May 17, 2023
Closed
@mikeferguson
Copy link
Member Author

@clalancette so this can't go into Iron - but can it get merged into rolling now, or does it have to wait until some certain milestone between the Iron and J-turtle release?

@clalancette
Copy link
Contributor

@clalancette so this can't go into Iron - but can it get merged into rolling now, or does it have to wait until some certain milestone between the Iron and J-turtle release?

Rolling is completely open for business!

@ahcorde
Copy link
Collaborator

ahcorde commented Jul 10, 2023

any updates here ?

@mikeferguson
Copy link
Member Author

@ahcorde - this is basically waiting on a review from a maintainer (I've fully implemented the downstream stuff for image_proc and depth_image_proc, so I'm confident this is all we need to add)

@ahcorde ahcorde merged commit 4965283 into ros-perception:rolling Jul 13, 2023
@ahcorde
Copy link
Collaborator

ahcorde commented Jul 13, 2023

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@mikeferguson mikeferguson deleted the lazy_subscriber_support branch November 13, 2023 22:15
mikeferguson added a commit to ros-perception/image_pipeline that referenced this pull request Jan 18, 2024
@mikeferguson
add support for lazy subscribers (#815)
335e878 
This implements #780 for ROS 2 distributions after Iron, where we have:

 * Connect/disconnect callbacks, per ros2/rmw#330 (this made it into Iron)
 * Updated APIs in ros-perception/image_common#272 (this is only in Rolling currently)
Kotochleb pushed a commit to Kotochleb/image_pipeline that referenced this pull request May 27, 2024
@mikeferguson
add support for lazy subscribers (ros-perception#815)
a1fffef 
This implements ros-perception#780 for ROS 2 distributions after Iron, where we have:

 * Connect/disconnect callbacks, per ros2/rmw#330 (this made it into Iron)
 * Updated APIs in ros-perception/image_common#272 (this is only in Rolling currently)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeferguson @clalancette @ahcorde