Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lazy subscription to republisher (backport #325) #327

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Oct 4, 2024

This PR add lazy subscription to republisher node using matched publisher events.

A simple use case I have in mind:

  1. I have a camera driver which retrieves jpeg-compressed images from camera and publishes them on image/compressed topic.
  2. I want to provide image topic with raw images for any nodes that need it.
  3. I don't want to decompress the images when there is no node which currently need the raw images.
    This is an automatic backport of pull request Add lazy subscription to republisher #325 done by Mergify.

@ahcorde
Copy link
Collaborator

ahcorde commented Oct 4, 2024

Pulls: #327
Gist: https://gist.githubusercontent.com/ahcorde/06f165ae03972f4f21a4036d0e411b7c/raw/f907a9e14b8b764e9f69bf337327c4c91a24c62c/ros2.repos
BUILD args: --packages-above-and-dependencies image_transport --packages-above-and-dependencies image_transport
TEST args: --packages-above image_transport --packages-above image_transport
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14664

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new member will break ABI, This requires some changes to make it ABI compatible

@bjsowa
Copy link
Contributor

bjsowa commented Oct 4, 2024

This new member will break ABI, This requires some changes to make it ABI compatible

Do you have any suggestions on how to achieve it?

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Collaborator

ahcorde commented Oct 11, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit d04d2c8 into jazzy Oct 15, 2024
2 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-325 branch October 15, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants