Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add camera_info_manager_py #335

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Add camera_info_manager_py #335

merged 2 commits into from
Nov 25, 2024

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Nov 25, 2024

@ahcorde
Add camera_info_manager_py
52862d2 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Nov 25, 2024
This was referenced Nov 25, 2024
Closed
Closed
@ahcorde
Copy link
Collaborator Author

ahcorde commented Nov 25, 2024

Pulls: #335
Gist: https://gist.githubusercontent.com/ahcorde/22eaec62b7954b7c0a5f1ca1110053d9/raw/72b685c91e95d9a60b93b757d999b02881b0d53a/ros2.repos
BUILD args: --packages-above-and-dependencies camera_info_manager_py --packages-above-and-dependencies camera_info_manager_py
TEST args: --packages-above camera_info_manager_py --packages-above camera_info_manager_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14862

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
make linters happy
a43556e 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Collaborator Author

ahcorde commented Nov 25, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Collaborator Author

ahcorde commented Nov 25, 2024

@civerachb-cpr do you mind to take a look?

@civerachb-cpr
Copy link

@ahcorde what do you need me to look at? According to #335 (comment) everything is passing.

The linting changes you made in a43556e all seem fine to me.

@ahcorde ahcorde merged commit d09c82c into rolling Nov 25, 2024
2 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/camera_info_manager_py branch November 25, 2024 17:34
@ahcorde
Copy link
Collaborator Author

ahcorde commented Nov 25, 2024

https://github.com/Mergifyio backport jazzy humble

@mergify Mergify
Copy link

mergify bot commented Nov 25, 2024 •
edited
Loading

backport jazzy humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 25, 2024
@ahcorde @mergify
Add camera_info_manager_py (#335)
b09118a 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit d09c82c)
@mergify mergify bot mentioned this pull request Nov 25, 2024
Merged
mergify bot pushed a commit that referenced this pull request Nov 25, 2024
@ahcorde @mergify
Add camera_info_manager_py (#335)
e7d5e51 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit d09c82c)
@mergify mergify bot mentioned this pull request Nov 25, 2024
Merged
ahcorde added a commit that referenced this pull request Nov 25, 2024
@mergify @ahcorde
Add camera_info_manager_py (#335) (#336)
476f219 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit d09c82c)

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Nov 26, 2024
@mergify @ahcorde
Add camera_info_manager_py (backport #335) (#337)
6b229d3 
* Add `camera_info_manager_py` (#335)

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @civerachb-cpr