-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ 11 is necessary to compile with latest image_geometry package #291
Comments
I believe I'm having the same issue. The build fails with: [ 52%] Building CXX object image_pipeline/image_proc/CMakeFiles/image_proc.dir/src/nodelets/rectify.cpp.o |
This is resolved by specifying c++ 11 in the CMakeLists: If having c++ 11 is an acceptable assumption moving forwards, I can make a PR to put this into the main branch. |
Yes, please do |
PR developed: #292 |
Sorry for the delay, 98670bd fixes it properly. |
The image_geometry package now compiles with C++ 11 by default: (https://github.com/ros-perception/vision_opencv/blob/8b5bbcbc1ce65734dc600695487909e0c67c1033/image_geometry/CMakeLists.txt#L15) , and uses std::shared_ptr: (https://github.com/ros-perception/vision_opencv/blob/8b5bbcbc1ce65734dc600695487909e0c67c1033/image_geometry/include/image_geometry/pinhole_camera_model.h#L273).
At present, image_pipeline does not compile with C++ 11, which causes the compiler to crash when compiling with image_geometry.
The text was updated successfully, but these errors were encountered: