Finish QoS updates #1019
Merged
Finish QoS updates #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also needs to be backported to jazzy - where QoS is horribly broken at the moment (the occasional unreliability of getTopicQoS() function now appears to be just "totally doesn't connect ever") |
* publishers default to reliable, no longer using getTopicQoSProfile() * publishers also support profile overrides where possible * subscribers default to matching (which also defaults to SensorDataQoS if no publisher)
mikeferguson
force-pushed
the
depth_proc_qos
branch
from
32ddad6 to
33c0130
Compare
This comment was marked as outdated.
This comment was marked as outdated.
going to use this for the tutorial
mikeferguson
force-pushed
the
depth_proc_qos
branch
from
b1f578c to
a37643a
Compare
6 tasks
ahcorde
approved these changes
Aug 19, 2024
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
This implements the remainder of #847: - Make sure publishers default to system defaults (reliable) - Add QoS overriding where possible (some of the image_transport / message_filters stuff doesn't really support that) - Use the matching heuristic for subscribers consistently (cherry picked from commit d272c4e) # Conflicts: # depth_image_proc/src/point_cloud_xyzi_radial.cpp
mikeferguson
added a commit
that referenced
this pull request
Aug 19, 2024
This implements the remainder of #847: - Make sure publishers default to system defaults (reliable) - Add QoS overriding where possible (some of the image_transport / message_filters stuff doesn't really support that) - Use the matching heuristic for subscribers consistently
mikeferguson
pushed a commit
that referenced
this pull request
Aug 19, 2024
This implements the remainder of #847: - Make sure publishers default to system defaults (reliable) - Add QoS overriding where possible (some of the image_transport / message_filters stuff doesn't really support that) - Use the matching heuristic for subscribers consistently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the remainder of #847: