Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add launch examples for image and mono and stereo #386

Merged
merged 2 commits into from
Oct 17, 2019

Conversation

yechun1
Copy link
Contributor

@yechun1 yechun1 commented Feb 28, 2019

  • launch default file
    ros2 launch image_publisher image_publisher_file.launch.py

  • launch monocular camera (/dev/video0)
    ros2 launch image_publisher image_publisher_mono.launch.py

  • launch stereo camera (/dev/video0 and /dev/video1)
    ros2 launch image_publisher image_publisher_stereo.launch.py

@SteveMacenski
Copy link
Member

@yechun1 can you fixthis PR to contain only your launch files? There's about 5,000 lines and some commits that aren't probably intended.

I'll merge then

@yechun1
Copy link
Contributor Author

yechun1 commented Oct 16, 2019

@SteveMacenski Sure, I'll resubmit the PR very soon.

launch examples to support:
1) load local image file and publish to the ros topic
1) load mono usb camera /dev/video0 and publish to the ros topic
1) load two usb cameras /dev/video0 amd /dev/video1, and publish to the left and right ros topic, this could simulate stereo camera.

* Publish image file to topic
  $ros2 launch image_publisher image_publisher_file.launch.py
    /camera/camera_info
    /camera/image_raw

* Publish monocular camera (/dev/video0)
  $ros2 launch image_publisher image_publisher_mono.launch.py
    /camera/camera_info
    /camera/image_raw

* Publish stereo camera (/dev/video0 and /dev/video1)
  $ros2 launch image_publisher image_publisher_stereo.launch.py
    /left/camera_info
    /left/image_raw
    /right/camera_info
    /right/image_raw
@yechun1 yechun1 force-pushed the ros2_image_publisher branch from 0bf9819 to 011ec96 Compare October 16, 2019 03:42
@yechun1
Copy link
Contributor Author

yechun1 commented Oct 16, 2019

Resubmitted the PR, please help review

[image_publisher] launch examples for file and mono and stereo

launch examples to support:

  1. load local image file and publish to the ros topic
  2. load mono usb camera /dev/video0 and publish to the ros topic
  3. load two usb cameras /dev/video0 amd /dev/video1, and publish to the left and right ros topic, this could simulate stereo camera.
  • Publish image file to topic
    $ros2 launch image_publisher image_publisher_file.launch.py
    /camera/camera_info
    /camera/image_raw

  • Publish monocular camera (/dev/video0)
    $ros2 launch image_publisher image_publisher_mono.launch.py
    /camera/camera_info
    /camera/image_raw

  • Publish stereo camera (/dev/video0 and /dev/video1)
    $ros2 launch image_publisher image_publisher_stereo.launch.py
    /left/camera_info
    /left/image_raw
    /right/camera_info
    /right/image_raw

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveMacenski
Copy link
Member

@yechun1 you're failing CI on essentially linter garbage, can you fix?

fix lint check error in launch file
@ghost
Copy link

ghost commented Oct 17, 2019

Hi @SteveMacenski , sorry for forgetting to run the test, now the issue fixed and CI test passed.

@SteveMacenski SteveMacenski merged commit 727a924 into ros-perception:ros2 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants