-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add launch examples for image and mono and stereo #386
add launch examples for image and mono and stereo #386
Conversation
@yechun1 can you fixthis PR to contain only your launch files? There's about 5,000 lines and some commits that aren't probably intended. I'll merge then |
@SteveMacenski Sure, I'll resubmit the PR very soon. |
launch examples to support: 1) load local image file and publish to the ros topic 1) load mono usb camera /dev/video0 and publish to the ros topic 1) load two usb cameras /dev/video0 amd /dev/video1, and publish to the left and right ros topic, this could simulate stereo camera. * Publish image file to topic $ros2 launch image_publisher image_publisher_file.launch.py /camera/camera_info /camera/image_raw * Publish monocular camera (/dev/video0) $ros2 launch image_publisher image_publisher_mono.launch.py /camera/camera_info /camera/image_raw * Publish stereo camera (/dev/video0 and /dev/video1) $ros2 launch image_publisher image_publisher_stereo.launch.py /left/camera_info /left/image_raw /right/camera_info /right/image_raw
0bf9819
to
011ec96
Compare
Resubmitted the PR, please help review [image_publisher] launch examples for file and mono and stereo launch examples to support:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yechun1 you're failing CI on essentially linter garbage, can you fix? |
fix lint check error in launch file
Hi @SteveMacenski , sorry for forgetting to run the test, now the issue fixed and CI test passed. |
launch default file
ros2 launch image_publisher image_publisher_file.launch.py
launch monocular camera (/dev/video0)
ros2 launch image_publisher image_publisher_mono.launch.py
launch stereo camera (/dev/video0 and /dev/video1)
ros2 launch image_publisher image_publisher_stereo.launch.py