Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate image_view docs #934

Merged
merged 5 commits into from
Feb 8, 2024
Merged

migrate image_view docs #934

merged 5 commits into from
Feb 8, 2024

Conversation

mikeferguson
Copy link
Member

  • migrate docs from ROS wiki
  • FIX: video recorder start/end services should only be advertised when feature is enabled
  • FIX: image remapping didn't work as expected/documented in stereo_image_proc

@mikeferguson mikeferguson requested a review from ahcorde February 8, 2024 18:28
@mikeferguson
Copy link
Member Author

mikeferguson commented Feb 8, 2024 •
edited
Loading

In porting the docs (and finding that many parameters weren't really documented), I came to this conclusion as well: #935

@mikeferguson mikeferguson merged commit 9485f5f into ros-perception:rolling Feb 8, 2024
3 checks passed
@mikeferguson mikeferguson deleted the image_view_docs branch February 8, 2024 21:18
Kotochleb pushed a commit to Kotochleb/image_pipeline that referenced this pull request May 27, 2024
@mikeferguson
migrate image_view docs (ros-perception#934)
60bcc2c 
* migrate docs from ROS wiki
* FIX: video recorder start/end services should only be advertised when
feature is enabled
* FIX: image remapping didn't work as expected/documented in
stereo_image_proc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
ros2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeferguson @ahcorde