Fix #63, regression in compressed_depth_image_transport with old bags #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcarroll
approved these changes
Apr 16, 2021
|
@tlind Thanks for contrition, I ran into same problem and this fix works for me on noetic. |
k-okada
added a commit
to k-okada/jsk_recognition
that referenced
this pull request
Dec 14, 2022
…16UC1; compressedDepth when playing existing bagfiles, see ros-perception/image_transport_plugins#64
k-okada
added a commit
to k-okada/jsk_recognition
that referenced
this pull request
Dec 14, 2022
…16UC1; compressedDepth when playing existing bagfiles, see ros-perception/image_transport_plugins#64
k-okada
added a commit
to k-okada/jsk_recognition
that referenced
this pull request
Dec 14, 2022
…16UC1; compressedDepth when playing existing bagfiles, see ros-perception/image_transport_plugins#64
k-okada
added a commit
to k-okada/jsk_recognition
that referenced
this pull request
Dec 14, 2022
…16UC1; compressedDepth when playing existing bagfiles, see ros-perception/image_transport_plugins#64
k-okada
added a commit
to k-okada/jsk_recognition
that referenced
this pull request
Dec 15, 2022
…16UC1; compressedDepth when playing existing bagfiles, see ros-perception/image_transport_plugins#64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this else-if clause fixes the error
Unsupported image format: 16UC1; compressedDepthwhen playing existing bagfiles. The regression had been introduced in commit a710d4a in thenoetic-develbranch by not correctly checking for old format strings.