Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed boost signals from CMakeLists.txt #77

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Removed boost signals from CMakeLists.txt #77

merged 1 commit into from
Jun 13, 2019

Conversation

bionade24
Copy link

With boost=>1.69 there signals isn't available anymore. As it's not necessary, it should be removed to be compatible to all boost versions.

Same issue here: ros/ros_comm#1580

With boost=>1.69 there `signals` isn't available anymore. As it's not necessary, it should be removed to be compatible to all boost versions.
@acxz
Copy link

acxz commented Jun 13, 2019

@jonbinney if you could take a look at this it would be much appreciated!

@jonbinney
Copy link
Contributor

@acxz thanks for the reminder! I tried this out and it doesn't break anything. @bionade24 thank you!

@jonbinney jonbinney merged commit 30e692e into ros-perception:indigo-devel Jun 13, 2019
@bionade24
Copy link
Author

When can we expect a new release of this repo?

@jonbinney
Copy link
Contributor

@bionade24 what ros distro are you using?

@bionade24
Copy link
Author

I'm maintaining the melodic AUR packages.

@jonbinney
Copy link
Contributor

Let me try doing a melodic release now

@bionade24
Copy link
Author

Thanks

@jonbinney
Copy link
Contributor

I just released version 1.7.7 of laser_asembler and version 1.8.7 of laser_assembler into melodic.

@bionade24
Copy link
Author

Thanks! No I can remove the patches out of the packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants