Remove signals from find_package(Boost COMPONENTS ...)

[de-vri-es]

The packages here use signals2, not signals. Only boost libraries with compiled code should be passed to find_package(Boost COMPONENTS ...), and the signals2 library has always been header only.

Boost 1.69 has removed the deprecated signals library, so the otherwise useless but harmless signals component now breaks the build.

[de-vri-es]

I doubt the test failure is related to this PR. Output of the failed test:

max time [60.0s] allotted for test [sub_to_multiple_pubs] of type [test_rospy/test_sub_to_multiple_pubs.py]
  File "/usr/lib/python2.7/unittest/case.py", line 329, in run
    testMethod()
  File "/tmp/ws/src/ros_comm/tools/rostest/src/rostest/runner.py", line 148, in fn
    self.test_parent.run_test(test)
  File "/tmp/ws/src/ros_comm/tools/rostest/src/rostest/rostest_parent.py", line 132, in run_test
    return self.runner.run_test(test)
  File "/tmp/ws/src/ros_comm/tools/roslaunch/src/roslaunch/launch.py", line 689, in run_test
    (test.time_limit, test.test_name, test.package, test.type))

It looks like a slow test that exceeded the allowed running time.

[lsr0]

This issue is now breaking the (unmodified) Arch linux packages, can only assume more places to follow.

[de-vri-es]

Closed and re-opened PR to re-trigger CI to see if the flaky test will pass on it's own.

[de-vri-es]

I guess not

[dirk-thomas]

Thanks for the patch.

The CI failure is due to a test known to be flaky - so ignoring it.

[de-vri-es]

Thanks!

[bionade24]

When does a new release of roscpp with this patch potentially come? I don't want to write a patch for AUR, upstream should be fixed.

[dirk-thomas]

Whenever I manage to get through the backlog. Hopefully February (no mention of the year though 🤣)...

[bionade24]

There is still no release with this patch. When does it come?