Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating tf2 C Headers #98

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from
Open

Deprecating tf2 C Headers #98

wants to merge 2 commits into from

Conversation

CursedRock17
Copy link

@CursedRock17 CursedRock17 commented Oct 29, 2024 •
edited
Loading

Related to this pull request in geometry2 in which we deprecated the .h style headers in favor of .hpp.

Edit: I should mention this is meant to be a preemptive PR for if/when the related pull request gets approved. I'm also working on a backport so there won't be distribution issues

@CursedRock17 CursedRock17 mentioned this pull request Oct 29, 2024
Open
@clalancette clalancette changed the base branch from kinetic-devel to rolling October 31, 2024 11:36
@clalancette
Copy link
Contributor

@CursedRock17 I retargeted this at the rolling branch, and this now needs a rebase.

@CursedRock17 CursedRock17 force-pushed the deprecate_c_headers branch 4 times, most recently from 29ae614 to 22f3aa9 Compare November 2, 2024 08:53
@CursedRock17 CursedRock17 reopened this Nov 3, 2024
@CursedRock17
Rebase Conflict 1
24f0ce5 
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
@CursedRock17
Solving Divergence
0cc0830 
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
@CursedRock17
Copy link
Author

A bit wonkey but it seems to like the rebase.

@clalancette
Copy link
Contributor

Pulls: ros2/geometry2#720, ros2/rviz#1289, #98
Gist: https://gist.githubusercontent.com/clalancette/b83127091186f2489c09c4c787585861/raw/3c16fd56b4d645d09b9cadf800da79cbfd1acbaf/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14792

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette clalancette mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quarkytale quarkytale Awaiting requested review from quarkytale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CursedRock17 @clalancette