Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide BT status to navigator in goalCompleted() function #2991

Closed
mrmitchadams opened this issue Jun 1, 2022 · 4 comments
Closed

Provide BT status to navigator in goalCompleted() function #2991

mrmitchadams opened this issue Jun 1, 2022 · 4 comments
Labels
enhancement New feature or request prehumble

Comments

@mrmitchadams
Copy link
Contributor

Feature request

Feature description

Each class that inherits from navigator.hpp has a chance to populate the result of its corresponding ROS action when the behavior tree finishes executing in the goalCompleted() function. In many cases it could be nice to have some context around the final status of the behavior tree while populating this result.

Implementation considerations

The most straightforward implementation would be to add another parameter to goalCompleted() for the behavior tree status (nav2_behavior_tree::BtStatus). The status is readily available where the completion callback is called, so passing in that extra argument would be trivial.

@SteveMacenski
Copy link
Member

Current all action result types are empty, but sure, feel free to submit a PR that sounds reasonable for future proofing

@SteveMacenski SteveMacenski added the enhancement New feature or request label Jun 1, 2022
@SteveMacenski
Copy link
Member

If you could do so in the next day, that would be appreciated, we're going to release to Humble this week and I'd like this in before that fork is made.

@mrmitchadams
Copy link
Contributor Author

Sure, I'll do that

@mrmitchadams mrmitchadams mentioned this issue Jun 2, 2022
7 tasks
@SteveMacenski
Copy link
Member

Merge imminent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prehumble
Projects
None yet
Development

No branches or pull requests

2 participants