Configurable spawn entity wait for service timeout #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have a reaonsable complex launch file and lots of DDS discovery traffic, sometimes five seconds isn't enough. This change makes the timeout configurable and changes the default timeout to thirty seconds. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
changed the title
chapulina
approved these changes
Mar 31, 2020
jacobperron
added a commit
to jacobperron/gazebo_ros_pkgs
that referenced
this pull request
Mar 31, 2020
Follow-up to ros-simulation#1072 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
chapulina
pushed a commit
that referenced
this pull request
Apr 1, 2020
* Use configurable timeout in other wait for service calls Follow-up to #1072 Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Update argument description Signed-off-by: Jacob Perron <jacob@openrobotics.org>
chapulina
pushed a commit
that referenced
this pull request
Jul 29, 2020
If we have a reaonsable complex launch file and lots of DDS discovery traffic, sometimes five seconds isn't enough. This change makes the timeout configurable and changes the default timeout to thirty seconds. Signed-off-by: Jacob Perron <jacob@openrobotics.org> (cherry picked from commit bd29f0d)
This was referenced Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have a reaonsable complex launch file and lots of DDS discovery traffic, sometimes five seconds isn't enough.
This change makes the timeout configurable and changes the default timeout to thirty seconds.