Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend -j1 when running tests. #440

Merged
merged 1 commit into from
Apr 26, 2016
Merged

Recommend -j1 when running tests. #440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,12 @@ We follow the [C++ ROS style guidelines](http://ros.org/wiki/CppStyleGuide) and
conventions as closely as possible. However, because the plugins inherit from Gazebo
classes and Gazebo follows a very different formatting standard, there are a few
exceptions where Gazebo's function names do not comply to the ROS guidelines.

## Tests

We encourage developers to include tests in their pull requests when possible,
both for bug fixes and new features.
Examples of tests are in the `gazebo_plugins/test*` folders.
Currently the tests must not be run in parallel (see issue
[issue 409](https://github.com/ros-simulation/gazebo_ros_pkgs/issues/409))
so it is recommented to use the `-j1` argument to `catkin run_tests`.