Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #612 for Gazebo9 #688

Merged
merged 2 commits into from
Mar 17, 2018
Merged

Commits on Mar 16, 2018

  1. Fix ros-simulation#612 for Gazebo9

    This commit fixes ros-simulation#612, but only for Gazebo9. Fixing it for Gazebo7
    (the version used in ROS Kinetic) requires the following PR to be
    backported to Gazebo 7 and 8:
    
    https://bitbucket.org/osrf/gazebo/pull-requests/2814/fix-issue-2111-by-providing-options-to/diff
    
    Once that PR has been backported, we can remove the GAZEBO_MAJOR_VERSION
    guards from this PR so that the fix is active for the older Gazebo
    versions as well.
    
    Tested on Gazebo7 (where it compiles, but doesn't change anything) and
    Gazebo9 (where it compiles and fixes the bug). I've tested it using the
    instructions I've put into this repo:
    
    https://github.com/mintar/mimic_joint_gazebo_tutorial
    mintar committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    9b15c68 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2018

  1. remove old ifdef

    scpeters authored Mar 17, 2018
    Configuration menu
    Copy the full SHA
    ffa38f9 View commit details
    Browse the repository at this point in the history