Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crystal changes for dashing #933

Merged
merged 3 commits into from
Jun 5, 2019

Conversation

shiveshkhaitan
Copy link

Address the crystal changes which have not been included in dashing

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting the changes, @shiveshkhaitan ! While testing this, I noticed some instructions were wrong, so I fixed them in 5663c96.

@chapulina chapulina merged commit 4fbcf39 into ros-simulation:ros2 Jun 5, 2019
@Karsten1987
Copy link

maybe I am doing something wrong here, but this PR made my compilation fail

Starting >>> gazebo_ros      
--- stderr: gazebo_ros                                      
/home/osrf/roscon_ws/src/gazebo_ros_pkgs/gazebo_ros/src/gazebo_ros_state.cpp:21:10: fatal error: gazebo_msgs/srv/get_entity_state.hpp: No such file or directory
 #include <gazebo_msgs/srv/get_entity_state.hpp>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/gazebo_ros_state.dir/src/gazebo_ros_state.cpp.o] Error 1
make[1]: *** [CMakeFiles/gazebo_ros_state.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
/home/osrf/roscon_ws/src/gazebo_ros_pkgs/gazebo_ros/t

reverting to 3.3.1 makes it work for me. Do I miss something here?

@chapulina
Copy link
Contributor

@Karsten1987, did you compile gazebo_msgs before gazebo_ros?

@shiveshkhaitan shiveshkhaitan deleted the crystal_changes branch June 19, 2019 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants