Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

fix: ignore include order #38

Closed
wants to merge 1 commit into from
Closed

fix: ignore include order #38

wants to merge 1 commit into from

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented May 20, 2022

Closes #36

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 requested a review from jtbandes May 20, 2022 00:40
@wep21
Copy link
Contributor Author

wep21 commented May 20, 2022

@jtbandes This is a little bit hacky way. How do you think?

@jtbandes
Copy link
Member

Maybe we should figure out why the CPPLINT.cfg file isn't being used? Do we need to move the file inside the package source dir?

@wep21 wep21 marked this pull request as draft May 20, 2022 02:10
@wep21
Copy link
Contributor Author

wep21 commented May 20, 2022

I guess ci is performed for each package, so CPPLINT.cfg in the root directory is removed when ci is performed.
Moving the cfg file into each package may solve the issue.

@james-rms
Copy link
Contributor

Closing due to inactivity and the fact that this codebase is moving to ros2/rosbag2. If you want to continue this thread of discussion there, we can create a new PR in rosbag2.

@james-rms james-rms closed this Nov 29, 2022
@wep21 wep21 deleted the fix/ignore-include-order branch November 29, 2022 06:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure in Rolling build farm
3 participants