Skip to content

Commit

Permalink
disable Shiboken with CMake < 3.14 (#87)
Browse files Browse the repository at this point in the history
  • Loading branch information
dirk-thomas committed Mar 2, 2020
1 parent 8fda1f5 commit b7d854e
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions cmake/shiboken_helper.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,16 @@ set(Python_ADDITIONAL_VERSIONS "${PYTHON_VERSION_MAJOR}.${PYTHON_VERSION_MINOR}"
find_package(PythonLibs "${PYTHON_VERSION_MAJOR}.${PYTHON_VERSION_MINOR}")

if(Shiboken2_FOUND AND PySide2_FOUND AND PYTHONLIBS_FOUND)
message(STATUS "Shiboken binding generator available.")
set(shiboken_helper_FOUND TRUE)
if(${CMAKE_VERSION} VERSION_LESS "3.14")
# the shiboken invocation needs CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES
# which is broken before CMake 3.14
# see https://gitlab.kitware.com/cmake/cmake/issues/18394
message(STATUS "Shiboken binding generator available but CMake version is older than 3.14.")
set(shiboken_helper_NOTFOUND TRUE)
else()
message(STATUS "Shiboken binding generator available.")
set(shiboken_helper_FOUND TRUE)
endif()
else()
message(STATUS "Shiboken binding generator NOT available.")
set(shiboken_helper_NOTFOUND TRUE)
Expand Down

0 comments on commit b7d854e

Please sign in to comment.