Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add -l prefix if it already exists. #59

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Don't add -l prefix if it already exists. #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmake/sip_configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ def __init__(self):


def custom_platform_lib_function(self, clib, framework=0):
if os.path.isabs(clib):
# Only add '-l' if a library doesn't already start with '-l' and is not an absolute path
if os.path.isabs(clib) or clib.startswith('-l'):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment describing why this check is necessary and libraries that already append -l

return clib
return default_platform_lib_function(self, clib, framework)

Expand Down