Skip to content

Commit

Permalink
many more imports
Browse files Browse the repository at this point in the history
  • Loading branch information
dirk-thomas committed Apr 20, 2016
1 parent c5766d7 commit c7cfadb
Show file tree
Hide file tree
Showing 45 changed files with 93 additions and 57 deletions.
2 changes: 1 addition & 1 deletion rqt_bag/src/rqt_bag/bag_timeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@


from python_qt_binding.QtCore import Qt, QTimer, qWarning, Signal
from python_qt_binding.QtGui import QGraphicsScene, QMessageBox
from python_qt_binding.QtWidgets import QGraphicsScene, QMessageBox

import bag_helper

Expand Down
3 changes: 2 additions & 1 deletion rqt_bag/src/rqt_bag/bag_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@

from python_qt_binding import loadUi
from python_qt_binding.QtCore import Qt, qWarning, Signal
from python_qt_binding.QtGui import QFileDialog, QGraphicsView, QIcon, QWidget
from python_qt_binding.QtGui import QIcon
from python_qt_binding.QtWidgets import QFileDialog, QGraphicsView, QWidget

import rosbag
import bag_helper
Expand Down
2 changes: 1 addition & 1 deletion rqt_bag/src/rqt_bag/plugins/raw_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
import math

from python_qt_binding.QtCore import Qt
from python_qt_binding.QtGui import QApplication, QAbstractItemView, QSizePolicy, QTreeWidget, QTreeWidgetItem
from python_qt_binding.QtWidgets import QApplication, QAbstractItemView, QSizePolicy, QTreeWidget, QTreeWidgetItem
from .topic_message_view import TopicMessageView


Expand Down
3 changes: 2 additions & 1 deletion rqt_bag/src/rqt_bag/plugins/topic_message_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
# POSSIBILITY OF SUCH DAMAGE.
from .message_view import MessageView

from python_qt_binding.QtGui import QAction, QIcon, QToolBar
from python_qt_binding.QtGui import QIcon
from python_qt_binding.QtWidgets import QAction, QToolBar


class TopicMessageView(MessageView):
Expand Down
4 changes: 2 additions & 2 deletions rqt_bag/src/rqt_bag/timeline_frame.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@

from python_qt_binding.QtCore import qDebug, QPointF, QRectF, Qt, qWarning, Signal
from python_qt_binding.QtGui import QBrush, QCursor, QColor, QFont, \
QFontMetrics, QGraphicsItem, QPen, \
QPolygonF
QFontMetrics, QPen, QPolygonF
from python_qt_binding.QtWidgets import QGraphicsItem
import rospy

import bisect
Expand Down
2 changes: 1 addition & 1 deletion rqt_bag/src/rqt_bag/timeline_menu.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
# ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
# POSSIBILITY OF SUCH DAMAGE.

from python_qt_binding.QtGui import QVBoxLayout, QMenu, QWidget, QDockWidget
from python_qt_binding.QtWidgets import QVBoxLayout, QMenu, QWidget, QDockWidget

class TopicPopupWidget(QWidget):
def __init__(self, popup_name, timeline, viewer_type, topic):
Expand Down
2 changes: 1 addition & 1 deletion rqt_bag/src/rqt_bag/topic_selection.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
import rosgraph

from python_qt_binding.QtCore import Qt, Signal
from python_qt_binding.QtGui import QWidget, QHBoxLayout, QVBoxLayout, QCheckBox, QScrollArea, QPushButton
from python_qt_binding.QtWidgets import QWidget, QHBoxLayout, QVBoxLayout, QCheckBox, QScrollArea, QPushButton

class TopicSelection(QWidget):

Expand Down
3 changes: 2 additions & 1 deletion rqt_bag_plugins/src/rqt_bag_plugins/image_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@
from rqt_bag import TopicMessageView
import image_helper

from python_qt_binding.QtGui import QGraphicsScene, QGraphicsView, QPixmap
from python_qt_binding.QtGui import QPixmap
from python_qt_binding.QtWidgets import QGraphicsScene, QGraphicsView


class ImageView(TopicMessageView):
Expand Down
3 changes: 2 additions & 1 deletion rqt_bag_plugins/src/rqt_bag_plugins/plot_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@

from python_qt_binding import loadUi
from python_qt_binding.QtCore import Qt, qWarning, Signal
from python_qt_binding.QtGui import QWidget, QPushButton, QTreeWidget, QTreeWidgetItem, QSizePolicy, QDoubleValidator, QIcon
from python_qt_binding.QtGui import QDoubleValidator, QIcon
from python_qt_binding.QtWidgets import QWidget, QPushButton, QTreeWidget, QTreeWidgetItem, QSizePolicy

from rqt_plot.data_plot import DataPlot

Expand Down
2 changes: 1 addition & 1 deletion rqt_console/src/rqt_console/console_settings_dialog.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
import os

from python_qt_binding import loadUi
from python_qt_binding.QtGui import QDialog
from python_qt_binding.QtWidgets import QDialog

from rqt_logger_level.logger_level_widget import LoggerLevelWidget
from rqt_logger_level.logger_level_service_caller import LoggerLevelServiceCaller
Expand Down
3 changes: 2 additions & 1 deletion rqt_console/src/rqt_console/console_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@
import os

from python_qt_binding import loadUi
from python_qt_binding.QtGui import QApplication, QCursor, QFileDialog, QHeaderView,QIcon, QMenu, QMessageBox, QTableView, QWidget
from python_qt_binding.QtGui import QCursor, QIcon
from python_qt_binding.QtWidgets import QApplication, QFileDialog, QHeaderView, QMenu, QMessageBox, QTableView, QWidget
from python_qt_binding.QtCore import QRegExp, Qt, qWarning

import time
Expand Down
3 changes: 2 additions & 1 deletion rqt_console/src/rqt_console/filters/custom_filter_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@

from python_qt_binding import loadUi
from python_qt_binding.QtCore import Qt
from python_qt_binding.QtGui import QPalette, QWidget
from python_qt_binding.QtGui import QPalette
from python_qt_binding.QtWidgets import QWidget

from rqt_py_common.ini_helper import pack, unpack

Expand Down
3 changes: 2 additions & 1 deletion rqt_console/src/rqt_console/filters/filter_wrapper_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@
import rospkg

from python_qt_binding import loadUi
from python_qt_binding.QtGui import QIcon, QWidget
from python_qt_binding.QtGui import QIcon
from python_qt_binding.QtWidgets import QWidget


class FilterWrapperWidget(QWidget):
Expand Down
3 changes: 2 additions & 1 deletion rqt_console/src/rqt_console/filters/list_filter_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@

from python_qt_binding import loadUi
from python_qt_binding.QtCore import Qt
from python_qt_binding.QtGui import QPalette, QWidget
from python_qt_binding.QtGui import QPalette
from python_qt_binding.QtWidgets import QWidget

from rqt_py_common.ini_helper import pack, unpack

Expand Down
2 changes: 1 addition & 1 deletion rqt_console/src/rqt_console/filters/text_filter_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
import rospkg

from python_qt_binding import loadUi
from python_qt_binding.QtGui import QWidget
from python_qt_binding.QtWidgets import QWidget


class TextFilterWidget(QWidget):
Expand Down
2 changes: 1 addition & 1 deletion rqt_console/src/rqt_console/filters/time_filter_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

from python_qt_binding import loadUi
from python_qt_binding.QtCore import QDateTime
from python_qt_binding.QtGui import QWidget
from python_qt_binding.QtWidgets import QWidget


class TimeFilterWidget(QWidget):
Expand Down
6 changes: 5 additions & 1 deletion rqt_console/src/rqt_console/message_proxy_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,11 @@
# POSSIBILITY OF SUCH DAMAGE.

from python_qt_binding.QtCore import Qt, qWarning
from python_qt_binding.QtGui import QBrush, QColor, QSortFilterProxyModel
try:
from python_qt_binding.QtCore import QSortFilterProxyModel # Qt 5
except ImportError:
from python_qt_binding.QtGui import QSortFilterProxyModel # Qt 4
from python_qt_binding.QtGui import QBrush, QColor

from .filters.filter_collection import FilterCollection
from .message import Message
Expand Down
3 changes: 2 additions & 1 deletion rqt_dep/src/rqt_dep/ros_pack_graph.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@

from python_qt_binding import loadUi
from python_qt_binding.QtCore import QFile, QIODevice, Qt, Signal, Slot, QAbstractListModel
from python_qt_binding.QtGui import QFileDialog, QGraphicsScene, QIcon, QImage, QPainter, QWidget, QCompleter
from python_qt_binding.QtGui import QIcon, QImage, QPainter
from python_qt_binding.QtWidgets import QFileDialog, QGraphicsScene, QWidget, QCompleter
from python_qt_binding.QtSvg import QSvgGenerator

import rosservice
Expand Down
3 changes: 2 additions & 1 deletion rqt_graph/src/rqt_graph/interactive_graphics_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
from __future__ import division

from python_qt_binding.QtCore import QPointF, QRectF, Qt
from python_qt_binding.QtGui import QGraphicsView, QTransform
from python_qt_binding.QtGui import QTransform
from python_qt_binding.QtWidgets import QGraphicsView


class InteractiveGraphicsView(QGraphicsView):
Expand Down
3 changes: 2 additions & 1 deletion rqt_graph/src/rqt_graph/ros_graph.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@

from python_qt_binding import loadUi
from python_qt_binding.QtCore import QAbstractListModel, QFile, QIODevice, Qt, Signal
from python_qt_binding.QtGui import QCompleter, QFileDialog, QGraphicsScene, QIcon, QImage, QPainter, QWidget
from python_qt_binding.QtGui import QIcon, QImage, QPainter
from python_qt_binding.QtWidgets import QCompleter, QFileDialog, QGraphicsScene, QWidget
from python_qt_binding.QtSvg import QSvgGenerator

import rosgraph.impl.graph
Expand Down
4 changes: 2 additions & 2 deletions rqt_launch/src/rqt_launch/launch_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@

from python_qt_binding import loadUi
from python_qt_binding.QtCore import QModelIndex, Signal
from python_qt_binding.QtGui import QDialog, QStandardItem, \
QStandardItemModel
from python_qt_binding.QtGui import QStandardItem, QStandardItemModel
from python_qt_binding.QtWidgets import QDialog
from rosgraph import rosenv
import roslaunch
from roslaunch.core import RLException
Expand Down
2 changes: 1 addition & 1 deletion rqt_launch/src/rqt_launch/node_delegate.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
# Author: Isaac Saito

from python_qt_binding.QtCore import Qt
from python_qt_binding.QtGui import QStyledItemDelegate
from python_qt_binding.QtWidgets import QStyledItemDelegate
import rospkg

from rqt_launch.node_widget import NodeWidget
Expand Down
3 changes: 2 additions & 1 deletion rqt_launch/src/rqt_launch/node_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
import os

from python_qt_binding import loadUi
from python_qt_binding.QtGui import QIcon, QLineEdit, QWidget
from python_qt_binding.QtGui import QIcon
from python_qt_binding.QtWidgets import QLineEdit, QWidget
import rospy

from rqt_launch.name_surrogate import NamesSurrogate
Expand Down
2 changes: 1 addition & 1 deletion rqt_launch/src/rqt_launch/status_indicator.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#! /usr/bin/env python

from python_qt_binding.QtGui import QLabel, QStyle
from python_qt_binding.QtWidgets import QLabel, QStyle
import rospy


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

from python_qt_binding import loadUi
from python_qt_binding.QtCore import qWarning
from python_qt_binding.QtGui import QWidget
from python_qt_binding.QtWidgets import QWidget


class LoggerLevelWidget(QWidget):
Expand Down
9 changes: 6 additions & 3 deletions rqt_plot/src/rqt_plot/data_plot/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,18 +42,21 @@

try:
from pyqtgraph_data_plot import PyQtGraphDataPlot
except ImportError:
except ImportError as e:
PyQtGraphDataPlot = None
print(e)

try:
from mat_data_plot import MatDataPlot
except ImportError:
except ImportError as e:
MatDataPlot = None
print(e)

try:
from qwt_data_plot import QwtDataPlot
except ImportError:
except ImportError as e:
QwtDataPlot = None
print(e)

# separate class for DataPlot exceptions, just so that users can differentiate
# errors from the DataPlot widget from exceptions generated by the underlying
Expand Down
3 changes: 2 additions & 1 deletion rqt_plot/src/rqt_plot/data_plot/mat_data_plot.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ def parse_version(s):
raise ImportError('A PySide version newer than 1.1.0 is required.')

from python_qt_binding.QtCore import Slot, Qt, qWarning, Signal
from python_qt_binding.QtGui import QWidget, QVBoxLayout, QSizePolicy, QColor
from python_qt_binding.QtGui import QColor
from python_qt_binding.QtWidgets import QWidget, QVBoxLayout, QSizePolicy

import operator
import matplotlib
Expand Down
3 changes: 2 additions & 1 deletion rqt_plot/src/rqt_plot/data_plot/pyqtgraph_data_plot.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
# POSSIBILITY OF SUCH DAMAGE.

from python_qt_binding.QtCore import Slot, Qt, qWarning, Signal
from python_qt_binding.QtGui import QColor, QVBoxLayout, QWidget
from python_qt_binding.QtGui import QColor
from python_qt_binding.QtWidgets import QVBoxLayout, QWidget

from pyqtgraph import PlotWidget, mkPen, mkBrush
import numpy
Expand Down
5 changes: 3 additions & 2 deletions rqt_plot/src/rqt_plot/data_plot/qwt_data_plot.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
import math
import sys

from python_qt_binding.QtCore import QEvent, QSize, QPointF, Qt, SIGNAL, Signal, Slot, qWarning
from python_qt_binding.QtCore import QEvent, QSize, QPointF, Qt, Signal, Slot, qWarning
from python_qt_binding.QtGui import QColor, QPen, QBrush, QVector2D
import Qwt

Expand Down Expand Up @@ -112,7 +112,8 @@ def eventFilter(self, _, event):
return False

def log(self, level, message):
self.emit(SIGNAL('logMessage'), level, message)
# self.emit(SIGNAL('logMessage'), level, message)
pass

def resizeEvent(self, event):
Qwt.QwtPlot.resizeEvent(self, event)
Expand Down
2 changes: 1 addition & 1 deletion rqt_py_common/src/rqt_py_common/layout_util.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
# Author: Isaac Saito

from python_qt_binding.QtCore import Qt
from python_qt_binding.QtGui import QWidgetItem
from python_qt_binding.QtWidgets import QWidgetItem
import roslib
import rospy

Expand Down
2 changes: 1 addition & 1 deletion rqt_py_common/src/rqt_py_common/plugin_container_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
import os

from python_qt_binding import loadUi
from python_qt_binding.QtGui import QWidget
from python_qt_binding.QtWidgets import QWidget
import rospkg
import rospy

Expand Down
2 changes: 1 addition & 1 deletion rqt_py_console/src/rqt_py_console/py_console.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
# ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
# POSSIBILITY OF SUCH DAMAGE.

from python_qt_binding.QtGui import QVBoxLayout, QWidget
from python_qt_binding.QtWidgets import QVBoxLayout, QWidget
from qt_gui.plugin import Plugin
from qt_gui_py_common.simple_settings_dialog import SimpleSettingsDialog
from py_console_widget import PyConsoleWidget
Expand Down
2 changes: 1 addition & 1 deletion rqt_py_console/src/rqt_py_console/py_console_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
import rospkg

from python_qt_binding import loadUi
from python_qt_binding.QtGui import QWidget
from python_qt_binding.QtWidgets import QWidget
import py_console_text_edit


Expand Down
5 changes: 4 additions & 1 deletion rqt_reconfigure/src/rqt_reconfigure/filter_children_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@
from __future__ import division

from python_qt_binding.QtCore import Qt, Signal
from python_qt_binding.QtGui import QSortFilterProxyModel
try:
from python_qt_binding.QtCore import QSortFilterProxyModel # Qt 5
except ImportError:
from python_qt_binding.QtGui import QSortFilterProxyModel # Qt 4
import rospy

from rqt_reconfigure.treenode_qstditem import TreenodeQstdItem
Expand Down
13 changes: 9 additions & 4 deletions rqt_reconfigure/src/rqt_reconfigure/node_selector_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,11 @@
import dynamic_reconfigure as dyn_reconf
from python_qt_binding import loadUi
from python_qt_binding.QtCore import Qt, Signal
from python_qt_binding.QtGui import (QHeaderView, QItemSelectionModel,
QWidget)
try:
from python_qt_binding.QtCore import QItemSelectionModel # Qt 5
except ImportError:
from python_qt_binding.QtGui import QItemSelectionModel # Qt 4
from python_qt_binding.QtWidgets import QHeaderView, QWidget
import rospy
from rospy.exceptions import ROSException
import rosservice
Expand Down Expand Up @@ -113,8 +116,10 @@ def __init__(self, parent, rospack, signal_msg=None):
# This 1 line is needed to enable horizontal scrollbar. This setting
# isn't available in .ui file.
# Ref. http://stackoverflow.com/a/6648906/577001
self._node_selector_view.header().setResizeMode(
0, QHeaderView.ResizeToContents)
try:
self._node_selector_view.header().setSectionResizeMode(0, QHeaderView.ResizeToContents) # Qt5
except AttributeError:
self._node_selector_view.header().setResizeMode(0, QHeaderView.ResizeToContents) # Qt4

# Setting slot for when user clicks on QTreeView.
self.selectionModel = self._node_selector_view.selectionModel()
Expand Down
4 changes: 2 additions & 2 deletions rqt_reconfigure/src/rqt_reconfigure/param_editors.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@

from python_qt_binding import loadUi
from python_qt_binding.QtCore import Signal
from python_qt_binding.QtGui import (QDoubleValidator, QIntValidator, QLabel,
QMenu, QWidget)
from python_qt_binding.QtGui import QDoubleValidator, QIntValidator
from python_qt_binding.QtWidgets import QLabel, QMenu, QWidget
from decimal import Decimal
import rospkg
import rospy
Expand Down
Loading

3 comments on commit c7cfadb

@ojura
Copy link
Contributor

@ojura ojura commented on c7cfadb May 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these imports be also provided for Qt4 by catching import exceptions? I believe this fails on Qt4.
e.g.
from python_qt_binding.QtGui import QWidget -> from python_qt_binding.QtWidgets import QWidget

@dirk-thomas
Copy link
Contributor Author

@dirk-thomas dirk-thomas commented on c7cfadb May 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python_qt_binding provides QtWidgets as an alias to QtGui in Qt4 (ros-visualization/python_qt_binding#31) for easy forward compatibility.

@ojura
Copy link
Contributor

@ojura ojura commented on c7cfadb May 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's true. I somehow ended in a situation where Ubuntu's python_qt_binding, which is missing that alias, got loaded instead of the ROS Kinetic one, alongside with Qt4, and then it failed.

Please sign in to comment.