fix (or silence) warnings of newer gcc / clang

-Wdeprecated-copy
-Wclass-memaccess
-Woverloaded-virtual

src/rviz/config.cpp

@@ -123,10 +123,6 @@ Config::Config() : node_(new Config::Node())
 {
 }
 
-Config::Config(const Config& source) : node_(source.node_)
-{
-}
-
 Config::Config(const QVariant& value) : node_(new Config::Node())
 {
   setValue(value);

src/rviz/config.h

@@ -131,7 +131,7 @@ class Config
   /** @brief Default constructor.  Creates an empty config object. */
   Config();
   /** @brief Copy constructor.  Copies only the reference to the data, not the data itself. */
-  Config(const Config& source);
+  Config(const Config& source) = default;
   /** @brief Convenience constructor, makes a Value type Config object with the given value. */
   Config(const QVariant& value);
 

src/rviz/ogre_helpers/point_cloud.cpp

@@ -413,7 +413,14 @@ void PointCloud::addPoints(Point* points, uint32_t num_points)
   }
 
   Point* begin = &points_.front() + point_count_;
+#if defined(__GNUC__) && (__GNUC__ >= 8)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wclass-memaccess"
+#endif
   memcpy(begin, points, sizeof(Point) * num_points);
+#if defined(__GNUC__) && (__GNUC__ >= 8)
+#pragma GCC diagnostic pop
+#endif
 
   uint32_t vpp = getVerticesPerPoint();
   Ogre::RenderOperation::OperationType op_type;

src/rviz/ogre_helpers/point_cloud.h

@@ -67,6 +67,8 @@ class PointCloudRenderable : public Ogre::SimpleRenderable
   PointCloudRenderable(PointCloud* parent, int num_points, bool use_tex_coords);
   ~PointCloudRenderable() override;
 
+  using Ogre::SimpleRenderable::getRenderOperation;
+
   Ogre::RenderOperation* getRenderOperation()
   {
     return &mRenderOp;

src/rviz/properties/property_tree_widget.h

@@ -55,11 +55,19 @@ class RVIZ_EXPORT PropertySelectionModel : public QItemSelectionModel
 class RVIZ_EXPORT PropertyTreeWidget : public QTreeView
 {
   Q_OBJECT
+
 public:
   PropertyTreeWidget(QWidget* parent = nullptr);
 
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Woverloaded-virtual"
+#endif
   /** @brief Set the data model this widget should view. */
   void setModel(PropertyTreeModel* model);
+#ifdef __clang__
+#pragma clang diagnostic pop
+#endif
   PropertyTreeModel* getModel() const
   {
     return model_;

src/rviz/selection/selection_manager.cpp

@@ -765,6 +765,7 @@ bool SelectionManager::render(Ogre::Viewport* viewport,
   ros::WallTime end = ros::WallTime::now();
   ros::WallDuration d = end - start;
   //  ROS_DEBUG("Render took [%f] msec", d.toSec() * 1000.0f);
+  Q_UNUSED(d);
 
   Ogre::MaterialManager::getSingleton().removeListener(this);
 

src/rviz/yaml_config_writer.cpp

@@ -57,7 +57,7 @@ void YamlConfigWriter::writeFile(const Config& config, const QString& filename)
       message_ = "Failed to open " + filename + " for writing.";
     }
   }
-  catch (std::exception ex)
+  catch (const std::exception& ex)
   {
     error_ = true;
     message_ = ex.what();