-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding option to transform map based on header timestamp #1066
Adding option to transform map based on header timestamp #1066
Conversation
LGTM. The name is reasonable IMHO. |
Cool, I'll try it out locally ASAP. @ayrton04 can you give an example scenario where I could test this out? |
I'm afraid I don't have code I can share, but if you turn a delayed laser scan into an occupancy grid with a timestamp and |
I've also found that just running a robot in sim and visualizing the local costmap works well. If it moves around a fair amount when the new parameter is set to false, it becomes much more stable after enabling it. |
I tried using the examples in |
Sure, I'll do that. |
I tried this again but I still couldn't see the difference. I must be doing something that doesn't exhibit the problem in the first place. Since the code lgtm and its hidden behind an option with a default behavior that hasn't changed, I'm going to go ahead and merge this. If someone else notices this doesn't resolve the problem we can fix it up then. |
Apologies, @wjwwood. I am running Xenial/Kinetic, and was hoping to use one of the open-source robot sims to produce an example, but never found a Kinetic-friendly one, and didn't get around to building an Indigo install in Xenial. |
Addresses #1065. Wasn't sure what name to give the property in the display window. I'm open to suggestions if anyone has any!