actionlib headers fail to compile on OS X

[wjwwood]

When compiling actionlib_tutorials on OS X with the latest hydro I get:

In file included from /Users/william/hydro/src/actionlib_tutorials/src/averaging_server.cpp:3:
In file included from /Users/william/hydro/new_install/include/actionlib/server/simple_action_server.h:42:
In file included from /Users/william/hydro/new_install/include/actionlib/server/action_server.h:52:
/Users/william/hydro/new_install/include/actionlib/server/action_server_base.h:163:12: error: default arguments cannot be added to an out-of-line definition of a member of a
      class template
      bool auto_start = false)  :
           ^            ~~~~~
In file included from /Users/william/hydro/src/actionlib_tutorials/src/fibonacci_server.cpp:2:
In file included from /Users/william/hydro/new_install/include/actionlib/server/simple_action_server.h:42:
In file included from /Users/william/hydro/new_install/include/actionlib/server/action_server.h:52:
/Users/william/hydro/new_install/include/actionlib/server/action_server_base.h:163:12: error: default arguments cannot be added to an out-of-line definition of a member of a
      class template
      bool auto_start = false)  :
           ^            ~~~~~
1 error generated.
1 error generated.
make[2]: *** [CMakeFiles/fibonacci_server.dir/src/fibonacci_server.cpp.o] Error 1
make[1]: *** [CMakeFiles/fibonacci_server.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make[2]: *** [CMakeFiles/averaging_server.dir/src/averaging_server.cpp.o] Error 1
make[1]: *** [CMakeFiles/averaging_server.dir/all] Error 2
Linking CXX executable /Users/william/hydro/devel_isolated/actionlib_tutorials/lib/actionlib_tutorials/averaging_client
Linking CXX executable /Users/william/hydro/devel_isolated/actionlib_tutorials/lib/actionlib_tutorials/fibonacci_client
[100%] Built target fibonacci_client
[100%] Built target averaging_client
make: *** [all] Error 2
<== Failed to process package 'actionlib_tutorials':
  Command '/Users/william/hydro/new_install/env.sh make -j4 -l4' returned non-zero exit status 2

Reproduce this error by running:
==> cd /Users/william/hydro/build_isolated/actionlib_tutorials && /Users/william/hydro/new_install/env.sh make -j4 -l4

Command failed, exiting.

[wjwwood]

Upgraded to a pull request, @jbohren @dirk-thomas can you review?

[dirk-thomas]

Reference #11 to keep track where the change was made - does not affect the groovy branch.

+1 @wjwwood Can you go ahead and merge/release 1.10.3 into Hydro?

[jbohren]

👍 Looks good to me.

[wjwwood]

Done. ros/rosdistro#1872