[Dashing backport]: Use .empty() to check for an empty string. (#132) #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
changed the title
|
Closing and re-opening to try and get appveyor to re-run (it failed for infrastructure reasons). |
Merged
When trying to install python3 from homebrew, travis was complaining that it couldn't overwrite python2 symlinks with python3 symlinks. Follow the advice given by homebrew and unlink python@2 before trying to install python3. This fixes travis on macOS for me. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This is essentially a port of PR #69 to ROS 2 so that clang-tidy will stop complaining about it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
dashing-backport-132
branch
from
cc20a61 to
11568e8
Compare
mjcarroll
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a port of PR #69 to ROS 2 so that clang-tidy
will stop complaining about it.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This is a backport of #132 to dashing.