Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overwrite tf2 cache entry with same timestamp #457

Conversation

schallerr
Copy link

Currently, entries with the same timestamp are all added to TimeCache. This might cause the internal list to grow indefinitely, since pruneList will not remove any entries.

This PR fixes this problem by overwriting an existing entry with the same timestamp, instead of inserting a new entry in the list.

@tfoote
Copy link
Member

tfoote commented May 1, 2020

This is a duplicate of #425 and #426 Please see the longer discussion there.

The test from this would be great to add to that too.

@tfoote
Copy link
Member

tfoote commented May 13, 2020

closing in favor of #459

@tfoote tfoote closed this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants