Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __getattr__ to handle sub in message_filters as standard one #700

Merged
merged 1 commit into from
Nov 15, 2015
Merged

Add __getattr__ to handle sub in message_filters as standard one #700

merged 1 commit into from
Nov 15, 2015

Conversation

wkentaro
Copy link
Contributor

No description provided.

@ros-pull-request-builder
Copy link
Member

Can one of the admins verify this patch?

@dirk-thomas
Copy link
Member

Should unregister then be removed?

@wkentaro wkentaro force-pushed the indigo-message_filters-getattr-subscriber branch from e743b51 to 0bf673a Compare November 10, 2015 19:34
@wkentaro
Copy link
Contributor Author

Thanks for a good suggestion. I removed unregister method.

@wkentaro
Copy link
Contributor Author

Could you please review and merge if it's fine?

@dirk-thomas
Copy link
Member

@ros-pull-request-builder

@ros-pull-request-builder
Copy link
Member

Test passed.
Refer to this link for build results: http://jenkins.ros.org/job/_pull_request-indigo-ros_comm/437/

@dirk-thomas
Copy link
Member

Thanks for the contribution.

dirk-thomas added a commit that referenced this pull request Nov 15, 2015
@dirk-thomas
Merge pull request #700 from wkentaro/indigo-message_filters-getattr-…
6ec3890 
…subscriber

Add __getattr__ to handle sub in message_filters as standard one
@dirk-thomas dirk-thomas merged commit 6ec3890 into ros:indigo-devel Nov 15, 2015
@wkentaro wkentaro deleted the indigo-message_filters-getattr-subscriber branch November 15, 2015 19:46
@wkentaro
Copy link
Contributor Author

Thanks.

@dirk-thomas
Copy link
Member

It will take quite a while until the patch will be available via Debian packages though. The last ros_comm release was just days ago. So the next one will likely be quite some time in the future.

@wkentaro
Copy link
Contributor Author

I see.

rsinnet pushed a commit to MisoRobotics/ros_comm that referenced this pull request Jun 19, 2017
@dirk-thomas
Merge pull request ros#700 from wkentaro/indigo-message_filters-getat…
0fbb1a2 
…tr-subscriber

Add __getattr__ to handle sub in message_filters as standard one
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkentaro @ros-pull-request-builder @dirk-thomas