Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rt_usb_9axisimu_driver: 1.0.0-1 in 'melodic/distribution.yaml' [bloom] #26460

Merged
merged 1 commit into from
Sep 15, 2020
Merged

rt_usb_9axisimu_driver: 1.0.0-1 in 'melodic/distribution.yaml' [bloom] #26460

merged 1 commit into from
Sep 15, 2020

Conversation

ShotaAk
Copy link
Contributor

@ShotaAk ShotaAk commented Sep 4, 2020

Increasing version of package(s) in repository rt_usb_9axisimu_driver to 1.0.0-1:

rt_usb_9axisimu_driver

* Contributors: Daisuke Sato, Shota Aoki

hidmic
hidmic reviewed Sep 7, 2020
View reviewed changes
melodic/distribution.yaml
url: https://github.com/rt-net-gbp/rt_usb_9axisimu_driver-release.git
version: 1.0.0-1
source:
test_pull_requests: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShotaAk just to double check, have you configured your repository accordingly (see here)?

Copy link
Contributor Author

@ShotaAk ShotaAk Sep 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your notice, I just updated the collaborator access rights and webhooks.

image

@ShotaAk ShotaAk mentioned this pull request Sep 8, 2020
Merged
ivanpauno
ivanpauno approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @hidmic can it be merged?

@tfoote
Copy link
Member

tfoote commented Sep 11, 2020

@ivanpauno I've confirmed @ros-pull-request-builder has access now

Screenshot from 2020-09-11 09-45-58

@ivanpauno
Copy link
Contributor

@ShotaAk We're holding melodic packages for the moment: https://discourse.ros.org/t/preparing-for-melodic-sync-2020-09-10/16350, I will merge after the sync happens.

@ShotaAk
Copy link
Contributor Author

ShotaAk commented Sep 12, 2020

@ivanpauno I understand. Thank you and everyone for reviewing this PR.

@clalancette clalancette merged commit 0b618be into ros:master Sep 15, 2020
@Tiryoh Tiryoh mentioned this pull request Oct 14, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic left review comments

@ivanpauno ivanpauno ivanpauno approved these changes

@clalancette clalancette Awaiting requested review from clalancette

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ShotaAk @tfoote @ivanpauno @hidmic @clalancette