Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rmw_connextdds: 0.3.0-1 in 'rolling/distribution.yaml' [bloom] #28598

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

asorbini
Copy link
Contributor

Increasing version of package(s) in repository rmw_connextdds to 0.3.0-1:

rmw_connextdds

* Add <buildtool_export_depend> for ament_cmake.
* Use default dds.transport.UDPv4.builtin.ignore_loopback_interface.

rmw_connextdds_common

* Add <buildtool_export_depend> for ament_cmake.
* Use default dds.transport.UDPv4.builtin.ignore_loopback_interface.

rmw_connextddsmicro

* Add <buildtool_export_depend> for ament_cmake.

rti_connext_dds_cmake_module

* Add <buildtool_export_depend> for ament_cmake.
* Add <depend> for rti-connext-dds-5.3.1

@cottsay
Copy link
Member

cottsay commented Mar 12, 2021

This package isn't affected by the recent updates to Bloom, but I would appreciate it nonetheless if you could update from bloom 0.10.1 to 0.10.2 for future releases.

Thanks!

@asorbini
Copy link
Contributor Author

Will do, thanks for the heads up @cottsay. Should I generate a new release and close this PR or can it be merged as is?

I know both my previous PRs failed to build (in package rmw_connextdds_common), and I'm not sure this one will succeed, but I tried to add some dependencies to the package.xml's which I was hoping to test.

@cottsay
Copy link
Member

cottsay commented Mar 12, 2021

Should I generate a new release and close this PR or can it be merged as is?

This one is okay as-is. Thanks for asking!

@ivanpauno ivanpauno merged commit 361e6e8 into ros:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants