Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python-modbus-pip to python.yaml #32010

Merged
merged 7 commits into from
Feb 15, 2022
Merged

Add python-modbus-pip to python.yaml #32010

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2c03a87
Pymodbus from pip
tgaspar Feb 2, 2022
1e656d6
Added rule to install pymodbus from pip
tgaspar Feb 2, 2022
d996bce
Adds Python3 support for pymodbus
tgaspar Feb 3, 2022
18107ad
Fixing alphabetical order
Feb 3, 2022
0e6948b
Added alias
Feb 10, 2022
08eb9ee
Adds focal and jammy exceptions
Feb 10, 2022
568be8b
Only melodic supports python2 packages
tgaspar Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions rosdep/python.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3694,6 +3694,13 @@ python-pymavlink:
python-pymodbus:
debian: [python-pymodbus]
ubuntu: [python-pymodbus]
python-pymodbus-pip:
ivanpauno marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change, since these are identical please make the python3- key an alias to the python- key.

python-pymodbus-pip: &migrate_eol_2027_04_30_python3_pymodbus_pip
  debian:
    pip:
      packages: [pymodbus]
  ubuntu:
    pip:
      packages: [pymodbus]
...
python3-pymodbus-pip: *migrate_eol_2027_04_30_python3_pymodbus_pip

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will do! Quick question though: how do I determine the EOL? Or better, how did you determine it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do I determine the EOL? Or better, how did you determine it?

I know we're transitioning to Ubuntu Jammy for ROS Rolling at the moment, so I assumed both that it counts as a supported platform and that it has the furthest away EOL date of April 2027.

debian:
pip:
packages: [pymodbus]
ubuntu:
pip:
packages: [pymodbus]
python-pymongo:
arch: [python2-pymongo]
debian: [python-pymongo]
Expand Down