Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in a rosdep key for python3-transforms3d. #33091

Merged
merged 2 commits into from
May 17, 2022

Conversation

clalancette
Copy link
Contributor

It is available in Ubuntu since Jammy, in Fedora since at
least Fedora 34. It is also available in Debian Sid and Bookworm,
but not any released Debian distribution yet.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

Please add the following dependency to the rosdep database.

Package name:

transforms3d

Package Upstream Source:

https://github.com/matthew-brett/transforms3d

Purpose of using this:

This dependency is being used by https://github.com/DLu/tf_transformations (which is released into all of Foxy, Galactic, Humble, and Rolling), though it is not currently declared as a dependency. Thus, it doesn't work out-of-the-box.

Distro packaging links:

Links to Distribution Packages

It is available in Ubuntu since Jammy, in Fedora since at
least Fedora 34.  It is also available in Debian Sid and Bookworm,
but not any released Debian distribution yet.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette requested a review from a team as a code owner May 6, 2022 13:11
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label May 6, 2022
@tfoote
Copy link
Member

tfoote commented May 6, 2022

Adding this we should simultaneously remove the old pip rule, otherwise people who use that will mask this rule. Or at least we should null it out for newer versions where the native versions are available.

@clalancette
Copy link
Contributor Author

Adding this we should simultaneously remove the old pip rule, otherwise people who use that will mask this rule. Or at least we should null it out for newer versions where the native versions are available.

Actually, this is an interesting question. The old key is python-transforms3d-pip, which is implicitly a Python 2 key. The new key here is python3-transforms3d, which is explicitly a Python3 key. So should we still remove the old pip rule?

@tfoote
Copy link
Member

tfoote commented May 9, 2022

pip keys are not implicitly a python2 key. Pip keys take the default python version platform of the system. So as of Noetic they are python3 keys and conflict.

Our general policy is that we should not have conflicting keys that will mask. So we can should add this. And set the old key to be explicitly for the older versions, and null for the platforms where it will conflict with the new packages.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Copy link
Contributor Author

I've mostly done this in a9bd5df . Note that debian is a weird case here, because in all stable versions, it is only available via pip. However, the packaged version is available in sid (the development version) and bookworm (the 'testing' version, that will become the next stable release). So for now, I just added pip entries for it and we can update it with the packages once they are available in a stable version.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is weird that Ubuntu's pulling ahead a bit. But with that stated this looks like a good rule. It will need to be updated at some point when people will want to make debian packages on top of it in the future.

@ivanpauno ivanpauno merged commit 44f8459 into master May 17, 2022
@clalancette clalancette deleted the clalancette/add-transforms3d branch June 10, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants