Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros2_kortex: 0.2.1-1 in 'iron/distribution.yaml' [bloom] #38075

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

moriarty
Copy link
Contributor

Increasing version of package(s) in repository ros2_kortex to 0.2.1-1:

kinova_gen3_6dof_robotiq_2f_85_moveit_config

  • No changes

kinova_gen3_7dof_robotiq_2f_85_moveit_config

* remove stomp for Humble from ros packages (#153 <https://github.com/PickNikRobotics/ros2_kortex/issues/153>)
  - STOMP is available if you build and use MoveIt from src but not
  if you have MoveIt installed from the ros distro
* Contributors: Alex Moriarty

kortex_api

* Change kortex_api header and library install locations (#156 <https://github.com/PickNikRobotics/ros2_kortex/issues/156>)
  This commit does several two main things:
  1) kortex_api now only installs the header files and they now do not pollute include
  2) kortex_driver gets the binary libKortexApiCpp.a itself
  kortex_driver gets the headers from kortex_api this avoids protobuf errors because
  those header files and the libKortexApiCpp.a were generated using non-system protobuf
  kortex_api cannot install the libKortexApiCpp.a because CMake does not allow installing library which was IMPORTED
  This should fix the debian packages which are currently released
* Contributors: Alex Moriarty

kortex_bringup

* fix missing dependencies (#152 <https://github.com/PickNikRobotics/ros2_kortex/issues/152>)
  This fixes missing dependencies which were available from source build
  but were missing from released binary
* Contributors: Alex Moriarty

kortex_description

* fix missing dependencies (#152 <https://github.com/PickNikRobotics/ros2_kortex/issues/152>)
  This fixes missing dependencies which were available from source build
  but were missing from released binary
* Contributors: Alex Moriarty

kortex_driver

* Change kortex_api header and library install locations (#156 <https://github.com/PickNikRobotics/ros2_kortex/issues/156>)
  This commit does several two main things:
  1) kortex_api now only installs the header files and they now do not pollute include
  2) kortex_driver gets the binary libKortexApiCpp.a itself
  kortex_driver gets the headers from kortex_api this avoids protobuf errors because
  those header files and the libKortexApiCpp.a were generated using non-system protobuf
  kortex_api cannot install the libKortexApiCpp.a because CMake does not allow installing library which was IMPORTED
  This should fix the debian packages which are currently released
* fix missing dependencies (#152 <https://github.com/PickNikRobotics/ros2_kortex/issues/152>)
  This fixes missing dependencies which were available from source build
  but were missing from released binary
* Contributors: Alex Moriarty

@github-actions github-actions bot added the iron Issue/PR is for the ROS 2 Iron distribution label Jul 26, 2023
@nuclearsandwich nuclearsandwich added the held for sync Issue/PR has been held because the distribution is in a sync hold label Jul 27, 2023
Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the current Iron sync hold is lifted this release is ready to merge.

@moriarty
Copy link
Contributor Author

moriarty commented Jul 27, 2023

@nuclearsandwich this fixes a error in the first version which will go into this iron sync, the header files from the KortexApi will pollute the /opt/ros/${rosdistro}/include

PickNikRobotics/ros2_kortex@365bb9e#diff-792373a47cffc322f7d8394aa22c94fb5638c363e3b14e6a3a8acd63cc421c4f

They now go into /opt/ros/${rosdistro}/include/kortex_api

Also fixes the location of a libKortexApiCpp.a by not installing it at all, the driver now pulls it in as needed as an imported library but doesn't install it. I was surprised this worked in local testing but I found that if I cleaned by build directory after building the api and before building the driver I was able to reproduce the failure.

@moriarty
Copy link
Contributor Author

Somewhat related to this PR. Kinova's Kortex API does not support Arm64 so I've added some PRs blacklisting it from the ros_buildfarm_config

@Yadunund Yadunund merged commit c67c6df into ros:master Jul 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
held for sync Issue/PR has been held because the distribution is in a sync hold iron Issue/PR is for the ROS 2 Iron distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants