Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rosdep] [catkin-lint] [debian/ubuntu] Use catkin-lint instead of python3-catkin-lint package #41004

Merged
merged 2 commits into from
May 7, 2024

Conversation

mikaelarguedas
Copy link
Member

@mikaelarguedas mikaelarguedas commented Apr 29, 2024

It looks like python3-catkin-tools was a name used in the past but not used anymore, and catkin-lint is used intead on all currently active distros.

Ubuntu

$ rmadison python3-catkin-lint
python3-catkin-lint | 1.6.6-1 | focal/universe | all

$ rmadison catkin-lint
catkin-lint | 1.6.6-1 | focal/universe | all
catkin-lint | 1.6.16-1 | jammy/universe | all
catkin-lint | 1.6.22-1 | mantic/universe | all
catkin-lint | 1.6.22-1 | noble/universe | all

Debian

$ rmadison python3-catkin-lint --url debian
python3-catkin-lint | 1.6.0-1 | oldoldstable | all
python3-catkin-lint | 1.6.12-1 | oldstable | all

$ rmadison catkin-lint --url debian
catkin-lint | 1.6.12-1 | oldstable | all
catkin-lint | 1.6.22-1 | stable | all
catkin-lint | 1.6.22-1 | testing | all
catkin-lint | 1.6.22-1 | unstable | all

$ rmadison python3-catkin-lint
 python3-catkin-lint | 1.6.6-1 | focal/universe | all

$ rmadison catkin-lint
 catkin-lint | 1.6.6-1  | focal/universe  | all
 catkin-lint | 1.6.16-1 | jammy/universe  | all
 catkin-lint | 1.6.22-1 | mantic/universe | all
 catkin-lint | 1.6.22-1 | noble/universe  | all
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas mikaelarguedas requested a review from a team as a code owner April 29, 2024 21:33
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Apr 29, 2024
@cottsay cottsay requested a review from nuclearsandwich April 29, 2024 21:36
@cottsay
Copy link
Member

cottsay commented Apr 30, 2024

Alternative question: Should we be distributing catkin-lint for more platforms from the bootstrap repository? We do import it for bionic and focal.

@mikaelarguedas
Copy link
Member Author

Alternative question: Should we be distributing catkin-lint for more platforms from the bootstrap repository? We do import it for bionic and focal.

TL;DR my feeling is that it wouldn't hurt to import it, could be nice but not necessary anymore.

IIRC For a while it was necessary to import it as it was not in the official Ubuntu repos and then the package was moving faster than Ubuntu distros so having it in the ROS repos allowed to benefit from more recent versions.
Looks like now the package is stable (last commit from Jan 2023).

@nuclearsandwich
Copy link
Member

Alternative question: Should we be distributing catkin-lint for more platforms from the bootstrap repository? We do import it for bionic and focal.

TL;DR my feeling is that it wouldn't hurt to import it, could be nice but not necessary anymore.

For a while it was necessary to import it as it was not in the official Ubuntu repos and then the package was moving faster than Ubuntu distros so having it in the ROS repos allowed to benefit from more recent versions.

Looks like now the package is stable (last commit from Jan 2023).

If the package was completely unavailable for our target platforms, as it was back in the day, then I think it would make sense to import and provide it via the ROS bootstrap repository. But now that it's available upstream and the upstream version is generally suitable. I'm very happy to have one less package, especially one that isn't currently maintained by members of the OSRF Infrastructure or ROS core teams, in the bootstrap repository's scope.

@nuclearsandwich nuclearsandwich merged commit 3b40485 into ros:master May 7, 2024
4 checks passed
@mikaelarguedas mikaelarguedas deleted the catkin-lint branch May 7, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants