Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in liboctomap-dev key. #41623

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Add in liboctomap-dev key. #41623

merged 1 commit into from
Jun 24, 2024

Conversation

clalancette
Copy link
Contributor

The situation with octomap and ROS is complicated.

As it stands, we effectively have a "vendor" package of octomap released into Humble, Iron, Jazzy, and Rolling. However, this is a problem on Jazzy and Rolling on Ubuntu 24.04 since the ABI between what we have released, and what is released in the operating system as "liboctomap-dev" is different. That means that using it with downstream packages just doesn't work.

The intent here is to add this key in, update all downstream packages to use this key, and then remove octomap from all of Humble, Iron, Jazzy, and Rolling. This will avoid the ABI problem, and just use the system package everywhere.

See #41622 for more information.

Note that I expect CI on this to fail until https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-71ae26cb75 lands in EPEL-9, about a week from now.

Please add the following dependency to the rosdep database.

Package name:

liboctomap-dev

Package Upstream Source:

https://github.com/octomap/octomap

Purpose of using this:

See the explanation above.

Several packages depend on having octomap available, including:

  • hpp-fcl
  • octomap_ros
  • gz_dartsim_vendor
  • mrpt2
  • moveit_ros_occupancy_map_monitor
  • moveit_core
  • geometric_shapes
  • octomap_rviz_plugins
  • octomap_server

Links to Distribution Packages

The situation with octomap and ROS is complicated.

As it stands, we effectively have a "vendor" package of
octomap released into Humble, Iron, Jazzy, and Rolling.
However, this is a problem on Jazzy and Rolling on Ubuntu 24.04
since the ABI between what we have released, and what is
released in the operating system as "liboctomap-dev" is
different.  That means that using it with downstream
packages just doesn't work.

The intent here is to add this key in, and then remove
octomap from all of Humble, Iron, Jazzy, and Rolling.
This will avoid the ABI problem, and just use the system
package everywhere.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette requested a review from a team as a code owner June 14, 2024 16:47
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Jun 14, 2024
Copy link
Contributor

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with happy PR jobs.

rosdep/base.yaml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants