Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bazel CI workflow #351

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Add bazel CI workflow #351

merged 2 commits into from
Dec 20, 2024

Conversation

mjcarroll
Copy link
Member

No description provided.

@mjcarroll
Add bazel CI workflow
f6ee8d1 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll self-assigned this Dec 19, 2024
@mjcarroll
Run on all PRs
3aea25b 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll mentioned this pull request Dec 19, 2024
Draft
@mjcarroll
Copy link
Member Author

This is still expected to fail until I add bazel-specific tests.

rhaschke
rhaschke reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of the folder test/bazel?
If that's just the build folder for bazel, I suggest to move it to .github/workflows/bazel.

.github/workflows/ci.bazelrc
@@ -0,0 +1,18 @@
# This file contains Bazel settings to apply on CI only.
# It is referenced with a --bazelrc option in the call to bazel in ci.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot find this reference. Can you please point me to the line in code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it used to be used as part of the upstream CI workflow, but when trying to find the reference, I find that it has been removed in https://github.com/bazel-contrib/.github/pull/11/files#diff-fcdc74e04f54e030b7b5cfde9bbcd1cc443162841efd9375481872e030b43a2bL153, which was reported upstream here: bazel-contrib/.github#23)

@rhaschke
Copy link
Contributor

Please integrate this PR into #350. They build upon each other anyway.

@mjcarroll mjcarroll merged commit 3aea25b into mjcarroll/bazel Dec 20, 2024
17 of 21 checks passed
@mjcarroll
Copy link
Member Author

What's the purpose of the folder test/bazel?

It's where an integration test of the bazel rules will go, I haven't implemented it yet. I will move it into bazel/integration_test as part of cleaning up the bazel-specific files.

@rhaschke rhaschke deleted the mjcarroll/bazel_ci branch December 21, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhaschke rhaschke rhaschke left review comments

Assignees

@mjcarroll mjcarroll

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjcarroll @rhaschke