Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: remove version number from MODULE.bazel #357

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

mjcarroll
Copy link
Member

@mjcarroll mjcarroll commented Feb 13, 2025

This is unneeded and injected at the central registry.
This helps eliminate maintainer churn around keeping this in sync.

Replaces: #355

This is unneeded and injected at the central registry.
This helps eliminate maintainer churn around keeping this in sync.

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll requested a review from rhaschke February 13, 2025 17:39
@mjcarroll mjcarroll self-assigned this Feb 13, 2025
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't yet understand how the version number is injected, but I just believe you.

@mjcarroll
Copy link
Member Author

It will happen in a patch in BCR: bazelbuild/bazel-central-registry#3731

I did this for the gazebo packages as well, and forgot that it was easier to just exclude the version from the upstream to decrease maintenance burden.

@mjcarroll mjcarroll merged commit ae90987 into ros2 Feb 13, 2025
21 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/bazel_updates branch February 13, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants